Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: third_party/WebKit/public/web/WebPlugin.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: For yosin@'s 2nd review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2014 Opera Software ASA. All rights reserved. 3 * Copyright (C) 2014 Opera Software ASA. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 virtual WebString selectionAsMarkup() const { return WebString(); } 149 virtual WebString selectionAsMarkup() const { return WebString(); }
150 150
151 virtual bool executeEditCommand(const WebString& name) { return false; } 151 virtual bool executeEditCommand(const WebString& name) { return false; }
152 virtual bool executeEditCommand(const WebString& name, const WebString& valu e) { return false; } 152 virtual bool executeEditCommand(const WebString& name, const WebString& valu e) { return false; }
153 153
154 // Sets composition text from input method, and returns true if the 154 // Sets composition text from input method, and returns true if the
155 // composition is set successfully. 155 // composition is set successfully.
156 virtual bool setComposition(const WebString& text, const WebVector<WebCompos itionUnderline>& underlines, int selectionStart, int selectionEnd) { return fals e; } 156 virtual bool setComposition(const WebString& text, const WebVector<WebCompos itionUnderline>& underlines, int selectionStart, int selectionEnd) { return fals e; }
157 // Confirms an ongoing composition and returns true if there is an ongoing 157 // Confirms an ongoing composition and returns true if there is an ongoing
158 // composition or the text is inserted. 158 // composition or the text is inserted.
159 virtual bool confirmComposition(const WebString& text, WebWidget::ConfirmCom positionBehavior selectionBehavior) { return false; } 159 virtual bool confirmComposition(const WebString& text, WebWidget::ConfirmCom positionBehavior selectionBehavior, int relativeCaretPosition) { return false; }
160 // Deletes the current selection plus the specified number of characters 160 // Deletes the current selection plus the specified number of characters
161 // before and after the selection or caret. 161 // before and after the selection or caret.
162 virtual void extendSelectionAndDelete(int before, int after) { } 162 virtual void extendSelectionAndDelete(int before, int after) { }
163 // If the given position is over a link, returns the absolute url. 163 // If the given position is over a link, returns the absolute url.
164 // Otherwise an empty url is returned. 164 // Otherwise an empty url is returned.
165 virtual WebURL linkAtPosition(const WebPoint& position) const { return WebUR L(); } 165 virtual WebURL linkAtPosition(const WebPoint& position) const { return WebUR L(); }
166 166
167 // Find interface. 167 // Find interface.
168 // Start a new search. The plugin should search for a little bit at a time so that it 168 // Start a new search. The plugin should search for a little bit at a time so that it
169 // doesn't block the thread in case of a large document. The results, along with the 169 // doesn't block the thread in case of a large document. The results, along with the
(...skipping 17 matching lines...) Expand all
187 187
188 virtual bool isPlaceholder() { return true; } 188 virtual bool isPlaceholder() { return true; }
189 189
190 protected: 190 protected:
191 ~WebPlugin() { } 191 ~WebPlugin() { }
192 }; 192 };
193 193
194 } // namespace blink 194 } // namespace blink
195 195
196 #endif 196 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698