Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: For compile error. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_ 5 #ifndef CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
6 #define CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_ 6 #define CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
7 7
8 #include "third_party/WebKit/public/web/WebPlugin.h" 8 #include "third_party/WebKit/public/web/WebPlugin.h"
9 9
10 #include <memory> 10 #include <memory>
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 bool executeEditCommand(const blink::WebString& name) override; 113 bool executeEditCommand(const blink::WebString& name) override;
114 bool executeEditCommand(const blink::WebString& name, 114 bool executeEditCommand(const blink::WebString& name,
115 const blink::WebString& value) override; 115 const blink::WebString& value) override;
116 bool setComposition( 116 bool setComposition(
117 const blink::WebString& text, 117 const blink::WebString& text,
118 const blink::WebVector<blink::WebCompositionUnderline>& underlines, 118 const blink::WebVector<blink::WebCompositionUnderline>& underlines,
119 int selectionStart, 119 int selectionStart,
120 int selectionEnd) override; 120 int selectionEnd) override;
121 bool confirmComposition( 121 bool confirmComposition(
122 const blink::WebString& text, 122 const blink::WebString& text,
123 blink::WebWidget::ConfirmCompositionBehavior selectionBehavior) override; 123 blink::WebWidget::ConfirmCompositionBehavior selection_behavior,
124 int relative_cursor_pos) override;
124 void extendSelectionAndDelete(int before, int after) override; 125 void extendSelectionAndDelete(int before, int after) override;
125 126
126 // MouseLockDispatcher::LockTarget implementation. 127 // MouseLockDispatcher::LockTarget implementation.
127 void OnLockMouseACK(bool succeeded) override; 128 void OnLockMouseACK(bool succeeded) override;
128 void OnMouseLockLost() override; 129 void OnMouseLockLost() override;
129 bool HandleMouseLockedInputEvent(const blink::WebMouseEvent& event) override; 130 bool HandleMouseLockedInputEvent(const blink::WebMouseEvent& event) override;
130 131
131 private: 132 private:
132 friend class base::DeleteHelper<BrowserPlugin>; 133 friend class base::DeleteHelper<BrowserPlugin>;
133 // Only the manager is allowed to create a BrowserPlugin. 134 // Only the manager is allowed to create a BrowserPlugin.
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 // Weak factory used in v8 |MakeWeak| callback, since the v8 callback might 203 // Weak factory used in v8 |MakeWeak| callback, since the v8 callback might
203 // get called after BrowserPlugin has been destroyed. 204 // get called after BrowserPlugin has been destroyed.
204 base::WeakPtrFactory<BrowserPlugin> weak_ptr_factory_; 205 base::WeakPtrFactory<BrowserPlugin> weak_ptr_factory_;
205 206
206 DISALLOW_COPY_AND_ASSIGN(BrowserPlugin); 207 DISALLOW_COPY_AND_ASSIGN(BrowserPlugin);
207 }; 208 };
208 209
209 } // namespace content 210 } // namespace content
210 211
211 #endif // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_ 212 #endif // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698