Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Source/web/WebViewFrameWidget.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be found 2 // Use of this source code is governed by a BSD-style license that can be found
3 // in the LICENSE file. 3 // in the LICENSE file.
4 4
5 #ifndef WebViewFrameWidget_h 5 #ifndef WebViewFrameWidget_h
6 #define WebViewFrameWidget_h 6 #define WebViewFrameWidget_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "public/web/WebFrameWidget.h" 9 #include "public/web/WebFrameWidget.h"
10 #include "wtf/Noncopyable.h" 10 #include "wtf/Noncopyable.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 const WebFloatSize& elasticOverscrollDelta, 59 const WebFloatSize& elasticOverscrollDelta,
60 float scaleFactor, 60 float scaleFactor,
61 float topControlsShownRatioDelta) override; 61 float topControlsShownRatioDelta) override;
62 void mouseCaptureLost() override; 62 void mouseCaptureLost() override;
63 void setFocus(bool) override; 63 void setFocus(bool) override;
64 bool setComposition( 64 bool setComposition(
65 const WebString& text, 65 const WebString& text,
66 const WebVector<WebCompositionUnderline>& underlines, 66 const WebVector<WebCompositionUnderline>& underlines,
67 int selectionStart, 67 int selectionStart,
68 int selectionEnd) override; 68 int selectionEnd) override;
69 bool confirmComposition() override; 69 bool confirmComposition(int newCursorPosition = 1) override;
70 bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) overri de; 70 bool confirmComposition(ConfirmCompositionBehavior selectionBehavior, int ne wCursorPosition = 1) override;
71 bool confirmComposition(const WebString& text) override; 71 bool confirmComposition(const WebString& text, int newCursorPosition = 1) ov erride;
72 bool compositionRange(size_t* location, size_t* length) override; 72 bool compositionRange(size_t* location, size_t* length) override;
73 WebTextInputInfo textInputInfo() override; 73 WebTextInputInfo textInputInfo() override;
74 WebTextInputType textInputType() override; 74 WebTextInputType textInputType() override;
75 bool selectionBounds(WebRect& anchor, WebRect& focus) const override; 75 bool selectionBounds(WebRect& anchor, WebRect& focus) const override;
76 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override; 76 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override;
77 bool isSelectionAnchorFirst() const override; 77 bool isSelectionAnchorFirst() const override;
78 bool caretOrSelectionRange(size_t* location, size_t* length) override; 78 bool caretOrSelectionRange(size_t* location, size_t* length) override;
79 void setTextDirection(WebTextDirection) override; 79 void setTextDirection(WebTextDirection) override;
80 bool isAcceleratedCompositingActive() const override; 80 bool isAcceleratedCompositingActive() const override;
81 bool isWebView() const override { return false; } 81 bool isWebView() const override { return false; }
(...skipping 16 matching lines...) Expand all
98 98
99 private: 99 private:
100 WebWidgetClient* m_client; 100 WebWidgetClient* m_client;
101 RefPtr<WebViewImpl> m_webView; 101 RefPtr<WebViewImpl> m_webView;
102 Persistent<WebLocalFrameImpl> m_mainFrame; 102 Persistent<WebLocalFrameImpl> m_mainFrame;
103 }; 103 };
104 104
105 } // namespace blink 105 } // namespace blink
106 106
107 #endif // WebViewFrameWidget_h 107 #endif // WebViewFrameWidget_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698