Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 const WebFloatSize& mainFrameDelta, 92 const WebFloatSize& mainFrameDelta,
93 const WebFloatSize& elasticOverscrollDelta, 93 const WebFloatSize& elasticOverscrollDelta,
94 float pageScaleDelta, 94 float pageScaleDelta,
95 float topControlsDelta) override; 95 float topControlsDelta) override;
96 void mouseCaptureLost() override; 96 void mouseCaptureLost() override;
97 void setFocus(bool enable) override; 97 void setFocus(bool enable) override;
98 bool setComposition( 98 bool setComposition(
99 const WebString& text, 99 const WebString& text,
100 const WebVector<WebCompositionUnderline>& underlines, 100 const WebVector<WebCompositionUnderline>& underlines,
101 int selectionStart, int selectionEnd) override; 101 int selectionStart, int selectionEnd) override;
102 bool confirmComposition() override; 102 bool confirmComposition(int newCursorPosition = 1) override;
103 bool confirmComposition(ConfirmCompositionBehavior selectionBehavior) overri de; 103 bool confirmComposition(ConfirmCompositionBehavior selectionBehavior, int ne wCursorPosition = 1) override;
104 bool confirmComposition(const WebString& text) override; 104 bool confirmComposition(const WebString& text, int newCursorPosition = 1) ov erride;
105 bool compositionRange(size_t* location, size_t* length) override; 105 bool compositionRange(size_t* location, size_t* length) override;
106 WebTextInputInfo textInputInfo() override; 106 WebTextInputInfo textInputInfo() override;
107 WebTextInputType textInputType() override; 107 WebTextInputType textInputType() override;
108 WebColor backgroundColor() const override; 108 WebColor backgroundColor() const override;
109 bool selectionBounds(WebRect& anchor, WebRect& focus) const override; 109 bool selectionBounds(WebRect& anchor, WebRect& focus) const override;
110 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override; 110 bool selectionTextDirection(WebTextDirection& start, WebTextDirection& end) const override;
111 bool isSelectionAnchorFirst() const override; 111 bool isSelectionAnchorFirst() const override;
112 bool caretOrSelectionRange(size_t* location, size_t* length) override; 112 bool caretOrSelectionRange(size_t* location, size_t* length) override;
113 void setTextDirection(WebTextDirection) override; 113 void setTextDirection(WebTextDirection) override;
114 bool isAcceleratedCompositingActive() const override; 114 bool isAcceleratedCompositingActive() const override;
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 WebColor m_baseBackgroundColor; 222 WebColor m_baseBackgroundColor;
223 223
224 SelfKeepAlive<WebFrameWidgetImpl> m_selfKeepAlive; 224 SelfKeepAlive<WebFrameWidgetImpl> m_selfKeepAlive;
225 }; 225 };
226 226
227 DEFINE_TYPE_CASTS(WebFrameWidgetImpl, WebFrameWidget, widget, widget->forSubfram e(), widget.forSubframe()); 227 DEFINE_TYPE_CASTS(WebFrameWidgetImpl, WebFrameWidget, widget, widget->forSubfram e(), widget.forSubframe());
228 228
229 } // namespace blink 229 } // namespace blink
230 230
231 #endif 231 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698