Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 1995333002: Handle newCursorPosition correctly for Android's commitText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 int selection_end); 348 int selection_end);
349 349
350 // Finishes an ongoing composition with the specified text. 350 // Finishes an ongoing composition with the specified text.
351 // A browser should call this function: 351 // A browser should call this function:
352 // * when it receives a WM_IME_COMPOSITION message with a GCS_RESULTSTR flag 352 // * when it receives a WM_IME_COMPOSITION message with a GCS_RESULTSTR flag
353 // (on Windows); 353 // (on Windows);
354 // * when it receives a "commit" signal of GtkIMContext (on Linux); 354 // * when it receives a "commit" signal of GtkIMContext (on Linux);
355 // * when insertText of NSTextInput is called (on Mac). 355 // * when insertText of NSTextInput is called (on Mac).
356 void ImeConfirmComposition(const base::string16& text, 356 void ImeConfirmComposition(const base::string16& text,
357 const gfx::Range& replacement_range, 357 const gfx::Range& replacement_range,
358 bool keep_selection); 358 bool keep_selection,
359 int new_cursor_pos = 1);
359 360
360 // Cancels an ongoing composition. 361 // Cancels an ongoing composition.
361 void ImeCancelComposition(); 362 void ImeCancelComposition();
362 363
363 bool ignore_input_events() const { 364 bool ignore_input_events() const {
364 return ignore_input_events_; 365 return ignore_input_events_;
365 } 366 }
366 367
367 // Whether forwarded WebInputEvents should be dropped. 368 // Whether forwarded WebInputEvents should be dropped.
368 bool ShouldDropInputEvents() const; 369 bool ShouldDropInputEvents() const;
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
809 base::TimeDelta new_content_rendering_delay_; 810 base::TimeDelta new_content_rendering_delay_;
810 811
811 base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_; 812 base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_;
812 813
813 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl); 814 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
814 }; 815 };
815 816
816 } // namespace content 817 } // namespace content
817 818
818 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 819 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698