Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Unified Diff: chrome/browser/ui/cocoa/user_manager_mac.mm

Issue 199533004: [Mac, Win] Show a user manager tutorial once per profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/user_manager_mac.mm
diff --git a/chrome/browser/ui/cocoa/user_manager_mac.mm b/chrome/browser/ui/cocoa/user_manager_mac.mm
index 1e132eb9bdf5584f48137acfe4e48598bd177e33..759ccf36cd6bb627bfb0b742cf5203a7ff5b7b28 100644
--- a/chrome/browser/ui/cocoa/user_manager_mac.mm
+++ b/chrome/browser/ui/cocoa/user_manager_mac.mm
@@ -25,7 +25,7 @@ namespace chrome {
// Declared in browser_dialogs.h so others don't have to depend on this header.
void ShowUserManager(const base::FilePath& profile_path_to_focus) {
- UserManagerMac::Show(profile_path_to_focus);
+ UserManagerMac::Show(profile_path_to_focus, false);
}
void HideUserManager() {
@@ -135,7 +135,8 @@ UserManagerMac::~UserManagerMac() {
}
// static
-void UserManagerMac::Show(const base::FilePath& profile_path_to_focus) {
+void UserManagerMac::Show(const base::FilePath& profile_path_to_focus,
+ bool show_tutorial) {
if (instance_) {
[instance_->window_controller_ show];
return;
@@ -147,7 +148,8 @@ void UserManagerMac::Show(const base::FilePath& profile_path_to_focus) {
profile_manager->CreateProfileAsync(
ProfileManager::GetGuestProfilePath(),
base::Bind(&UserManagerMac::OnGuestProfileCreated,
- profile_path_to_focus),
+ profile_path_to_focus,
+ show_tutorial),
base::string16(),
base::string16(),
std::string());
@@ -171,6 +173,7 @@ void UserManagerMac::WindowWasClosed() {
void UserManagerMac::OnGuestProfileCreated(
const base::FilePath& profile_path_to_focus,
+ bool show_tutorial,
Profile* guest_profile,
Profile::CreateStatus status) {
if (status != Profile::CREATE_STATUS_INITIALIZED)
@@ -181,7 +184,9 @@ void UserManagerMac::OnGuestProfileCreated(
// Tell the webui which user pod should be focused.
std::string page = chrome::kChromeUIUserManagerURL;
- if (!profile_path_to_focus.empty()) {
+ if (show_tutorial) {
+ page += "#tutorial";
+ } else if (!profile_path_to_focus.empty()) {
ProfileInfoCache& cache =
g_browser_process->profile_manager()->GetProfileInfoCache();
size_t index = cache.GetIndexOfProfileWithPath(profile_path_to_focus);
@@ -192,4 +197,3 @@ void UserManagerMac::OnGuestProfileCreated(
}
[instance_->window_controller_ showURL:GURL(page)];
}
-

Powered by Google App Engine
This is Rietveld 408576698