[Mac, Win] Show a user manager tutorial once per profile.

chrome/browser/ui/views/user_manager_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/user_manager_view.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile_manager.h"
@@ skipping 28 matching lines @@
 // Default window size.
 const int kWindowWidth = 900;
 const int kWindowHeight = 700;
 
 }
 
 namespace chrome {
 
 // Declared in browser_dialogs.h so others don't have to depend on this header.
 void ShowUserManager(const base::FilePath& profile_path_to_focus) {
-  UserManagerView::Show(profile_path_to_focus);
+  UserManagerView::Show(profile_path_to_focus, false);
 }
 
 void HideUserManager() {
   UserManagerView::Hide();
 }
 
 }  // namespace chrome
 
 // static
 UserManagerView* UserManagerView::instance_ = NULL;
 
 UserManagerView::UserManagerView(Profile* profile)
     : web_view_(new views::WebView(profile)) {
   SetLayoutManager(new views::FillLayout);
   AddChildView(web_view_);
 }
 
 UserManagerView::~UserManagerView() {
 }
 
 // static
-void UserManagerView::Show(const base::FilePath& profile_path_to_focus) {
+void UserManagerView::Show(const base::FilePath& profile_path_to_focus,
+                           bool show_tutorial) {
   ProfileMetrics::LogProfileSwitchUser(ProfileMetrics::OPEN_USER_MANAGER);
   if (instance_) {
     // If there's a user manager window open already, just activate it.
     instance_->GetWidget()->Activate();
     return;
   }
 
   // Create the guest profile, if necessary, and open the user manager
   // from the guest profile.
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   profile_manager->CreateProfileAsync(
       ProfileManager::GetGuestProfilePath(),
       base::Bind(&UserManagerView::OnGuestProfileCreated,
-                 profile_path_to_focus),
+                 profile_path_to_focus,
+                 show_tutorial),

[Alexei Svitkine (slow), 2014/03/14 21:04:40]

I do wonder if there's a way to design this so that this much logic isn't
repeated between the Mac and Windows implementations....

[noms (inactive), 2014/03/17 21:52:23]

Added a helper function in profile_window.cc that does all this magic and runs a
callback for the platform specific code.

On 2014/03/14 21:04:40, Alexei Svitkine wrote:

       base::string16(),
       base::string16(),
       std::string());
 }
 
 // static
 void UserManagerView::Hide() {
   if (instance_)
     instance_->GetWidget()->Close();
 }
 
 // static
 bool UserManagerView::IsShowing() {
   return instance_ ? instance_->GetWidget()->IsActive() : false;
 }
 
 void UserManagerView::OnGuestProfileCreated(
     const base::FilePath& profile_path_to_focus,
+    bool show_tutorial,
     Profile* guest_profile,
     Profile::CreateStatus status) {
   if (status != Profile::CREATE_STATUS_INITIALIZED)
     return;
 
   instance_ = new UserManagerView(guest_profile);
   DialogDelegate::CreateDialogWidget(instance_, NULL, NULL);
 
   gfx::NativeWindow window = instance_->GetWidget()->GetNativeWindow();
   instance_->keep_alive_.reset(new AutoKeepAlive(window));
 
 #if defined(OS_WIN)
   // Set the app id for the task manager to the app id of its parent
   ui::win::SetAppIdForWindow(
       ShellIntegration::GetChromiumModelIdForProfile(
           guest_profile->GetPath()),
       views::HWNDForWidget(instance_->GetWidget()));
 #endif
   instance_->GetWidget()->Show();
 
   // Tell the webui which user pod should be focused.
   std::string page = chrome::kChromeUIUserManagerURL;
 
-  if (!profile_path_to_focus.empty()) {
+  if (show_tutorial) {
+    page += "#tutorial";
+  } else if (!profile_path_to_focus.empty()) {
     ProfileInfoCache& cache =
         g_browser_process->profile_manager()->GetProfileInfoCache();
     size_t index = cache.GetIndexOfProfileWithPath(profile_path_to_focus);
     if (index != std::string::npos) {
       page += "#";
       page += base::IntToString(index);
     }
   }
 
   instance_->web_view_->LoadInitialURL(GURL(page));
@@ skipping 24 matching lines @@
   // Now that the window is closed, we can allow a new one to be opened.
   // (WindowClosing comes in asynchronously from the call to Close() and we
   // may have already opened a new instance).
   if (instance_ == this)
     instance_ = NULL;
 }
 
 bool UserManagerView::UseNewStyleForThisDialog() const {
   return false;
 }