[Mac, Win] Show a user manager tutorial once per profile.

chrome/browser/ui/views/profile_chooser_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profile_chooser_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile_info_util.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/profiles/profile_window.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/signin/mutable_profile_oauth2_token_service.h"
 #include "chrome/browser/signin/profile_oauth2_token_service.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/views/user_manager_view.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 484 matching lines @@
                                    profiles::ProfileSwitchingDoneCallback());
   } else if (sender == end_guest_button_) {
     profiles::CloseGuestProfileWindows();
   } else if (sender == users_button_) {
     // Only non-guest users appear in the User Manager.
     base::FilePath profile_path;
     if (!end_guest_button_) {
       size_t active_index = avatar_menu_->GetActiveProfileIndex();
       profile_path = avatar_menu_->GetItemAt(active_index).profile_path;
     }
-    chrome::ShowUserManager(profile_path);
+
+    // Show the tutorial if it hasn't been shown before. This is the same
+    // logic as in profile_chooser_controller.mm.
+    PrefService* pref_service = browser_->profile()->GetPrefs();
+    bool tutorial_shown = pref_service->GetBoolean(
+        prefs::kProfileUserManagerTutorialShown);
+    if (!tutorial_shown)
+      pref_service->SetBoolean(prefs::kProfileUserManagerTutorialShown, true);
+    UserManagerView::Show(
+        profile_path,
+        tutorial_shown ? profiles::USER_MANAGER_NO_TUTORIAL :
+                         profiles::USER_MANAGER_TUTORIAL_OVERVIEW);

[Alexei Svitkine (slow), 2014/03/18 15:50:33]

I think it would be better to keep the entry point as chrome::ShowUserManager()
and have this logic contained in that function that will be shared between
platforms.

I'm thinking you can have a cross-platform implementation of
chrome::ShowUserManager() that has the above logic and that has some a short set
of of ifdefs that then calls either UserManagerView::Show() or
UserManagerMac::Show() or whichever.

This allows to keep this logic in one place.

(You can probably change chrome::ShowUserManager() to
profiles::ShowUserManager() and put that function in profile_window.h like
you've done for the other code.)

[noms (inactive), 2014/03/18 17:39:09]

The problem with that is that ShowUserManager() can be called by code that
doesn't have a valid Profile* pointer (for example, trying to switch to a locked
profile from the fast user switcher), so you can't assume that you can always
read the preference in there. I can add the tutorial_mode to ShowUserManager(),
though, so that all of this logic can go into a helper function which can be
called from both mac and windows (since they each implement
chrome::ShowUserManager in their own way). Sounds good?

On 2014/03/18 15:50:33, Alexei Svitkine wrote:

[Alexei Svitkine (slow), 2014/03/18 17:45:40]

I see - okay, sgtm.

[noms (inactive), 2014/03/19 15:58:20]

Done.

   } else if (sender == add_user_button_) {
     profiles::CreateAndSwitchToNewProfile(
         browser_->host_desktop_type(),
         profiles::ProfileSwitchingDoneCallback(),
         ProfileMetrics::ADD_NEW_USER_ICON);
   } else if (sender == add_account_button_) {
     ShowView(GAIA_ADD_ACCOUNT_VIEW, avatar_menu_.get());
   } else if (sender == current_profile_photo_->change_photo_button()) {
     avatar_menu_->EditProfile(avatar_menu_->GetActiveProfileIndex());
   } else if (sender == tutorial_ok_button_) {
@@ skipping 405 matching lines @@
   if (!is_primary_account) {
     email_button->set_menu_marker(menu_marker);
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   }
   layout->StartRow(1, 0);
   layout->AddView(email_button);
 
   // Save the original email address, as the button text could be elided.
   current_profile_accounts_map_[email_button] = account;
 }