[Mac, Win] Show a user manager tutorial once per profile.

chrome/browser/profiles/profile_window.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_window.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
+#include "base/strings/string_number_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
+#include "chrome/common/url_constants.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/user_metrics.h"
 
 #if !defined(OS_IOS)
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_list_observer.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 #endif  // !defined (OS_IOS)
@@ skipping 87 matching lines @@
   // Passing true for |always_create| means we won't duplicate the code that
   // tries to find a browser.
   profiles::FindOrCreateNewWindowForProfile(
       profile,
       is_process_startup,
       is_first_run,
       desktop_type,
       true);
 }
 
+void OnUserManagerGuestProfileCreated(

[Alexei Svitkine (slow), 2014/03/18 15:50:33]

Add a comment.

[noms (inactive), 2014/03/19 15:58:20]

Done.

+    const base::FilePath& profile_path_to_focus,
+    profiles::UserManagerTutorialMode tutorial_mode,
+    const base::Callback<void(Profile*, const std::string&)>& callback,
+    Profile* guest_profile,
+    Profile::CreateStatus status) {
+  if (status != Profile::CREATE_STATUS_INITIALIZED)
+    return;
+
+  // Tell the webui which user pod should be focused.
+  std::string page = chrome::kChromeUIUserManagerURL;
+
+  if (tutorial_mode == profiles::USER_MANAGER_TUTORIAL_OVERVIEW) {
+    page += "#tutorial";
+  } else if (!profile_path_to_focus.empty()) {
+    ProfileInfoCache& cache =

[Alexei Svitkine (slow), 2014/03/18 15:50:33]

Nit: const

[noms (inactive), 2014/03/19 15:58:20]

Done.

[Alexei Svitkine (slow), 2014/03/19 16:37:01]

Optional nit: I think in this case you should be able to do a const& since
GetIndexOfProfileWithPath() is const.

+        g_browser_process->profile_manager()->GetProfileInfoCache();
+    size_t index = cache.GetIndexOfProfileWithPath(profile_path_to_focus);
+    if (index != std::string::npos) {
+      page += "#";
+      page += base::IntToString(index);
+    }
+  }
+
+  if (!callback.is_null())
+    callback.Run(guest_profile, page);
+}
+
 }  // namespace
 
 namespace profiles {
 
 void FindOrCreateNewWindowForProfile(
     Profile* profile,
     chrome::startup::IsProcessStartup process_startup,
     chrome::startup::IsFirstRun is_first_run,
     chrome::HostDesktopType desktop_type,
     bool always_create) {
@@ skipping 81 matching lines @@
   DCHECK(profile);
   ProfileInfoCache& cache =
       g_browser_process->profile_manager()->GetProfileInfoCache();
 
   size_t index = cache.GetIndexOfProfileWithPath(profile->GetPath());
   cache.SetProfileSigninRequiredAtIndex(index, true);
   chrome::ShowUserManager(profile->GetPath());
   BrowserList::CloseAllBrowsersWithProfile(profile);
 }
 
+void CreateGuestProfileForUserManager(
+    const base::FilePath& profile_path_to_focus,
+    profiles::UserManagerTutorialMode tutorial_mode,
+    const base::Callback<void(Profile*, const std::string&)>& callback) {
+
+  // Create the guest profile, if necessary, and open the User Manager
+  // from the guest profile.
+  ProfileManager* profile_manager = g_browser_process->profile_manager();
+  profile_manager->CreateProfileAsync(
+      ProfileManager::GetGuestProfilePath(),
+      base::Bind(&OnUserManagerGuestProfileCreated,
+                 profile_path_to_focus,
+                 tutorial_mode,
+                 callback),
+      base::string16(),

[Alexei Svitkine (slow), 2014/03/18 15:50:33]

Nit: Can you add /* */ comments with the name of these params?

[noms (inactive), 2014/03/19 15:58:20]

This is a pretty standard call for this function (used in 3 other places in the
file). I think the comments wouldn't add a whole lot of meaning.

On 2014/03/18 15:50:33, Alexei Svitkine wrote:

+      base::string16(),
+      std::string());
+}
+
 }  // namespace profiles