Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1995323002: Revert of Refactor script position calculation (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
Reviewers:
jgruber1, Yang, jgruber
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@20160517_refactor_position_info
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Refactor script position calculation (patchset #3 id:40001 of https://codereview.chromium.org/2003483002/ ) Reason for revert: Crashes gc stress with custom snapshot: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/5763 Original issue's description: > Refactor script position calculation > > Script position calculation logic (i.e. line & column numbers for a > given code position) is now based on a single method > Script::GetPositionInfo(). Refactored related code in isolate.cc and > js/messages.js to use the new method. The line_ends accessor is still > in use by chromium and thus cannot be removed yet. > > R=yangguo@chromium.org > BUG= > > Committed: https://crrev.com/2f3879d54633c4076d38e9fc85b6e2e157c61548 > Cr-Commit-Position: refs/heads/master@{#36398} TBR=yangguo@chromium.org,jgruber@chromium.org,jgruber@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/2f8a0077ae838e9eab9a2f44e49970bf7e73254a Cr-Commit-Position: refs/heads/master@{#36403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -368 lines) Patch
M src/debug/mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-symbols.h View 4 chunks +0 lines, -5 lines 0 comments Download
M src/isolate.cc View 1 chunk +18 lines, -7 lines 0 comments Download
M src/js/messages.js View 9 chunks +122 lines, -19 lines 0 comments Download
M src/objects.h View 2 chunks +8 lines, -27 lines 0 comments Download
M src/objects.cc View 1 chunk +33 lines, -84 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +45 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Refactor script position calculation
4 years, 7 months ago (2016-05-20 10:48:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995323002/1
4 years, 7 months ago (2016-05-20 10:48:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 10:49:03 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 10:49:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f8a0077ae838e9eab9a2f44e49970bf7e73254a
Cr-Commit-Position: refs/heads/master@{#36403}

Powered by Google App Engine
This is Rietveld 408576698