Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1995303003: Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #1 id:1 of https://codereview.chromium.org/1968453002/ ) Reason for revert: Breaks a KCS demo: BUG=chromium:611976 Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Trying to re-land http://crrev.com/1948453002 after fixing assembler-x64.cc in http://crrev.com/1962563003. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter. > > Committed: https://crrev.com/2da70f853d7f680d491c37c72d5ef04a85497ba9 > Cr-Commit-Position: refs/heads/master@{#36136} TBR=bmeurer@chromium.org,epertoso@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/767c34dfae4b0e523c38b0f44e1db70b603d41bf Cr-Commit-Position: refs/heads/master@{#36413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -152 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 3 chunks +14 lines, -59 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 4 chunks +17 lines, -73 lines 0 comments Download
M test/cctest/compiler/test-run-load-store.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
titzer
4 years, 7 months ago (2016-05-20 13:32:43 UTC) #1
Created Revert of [turbofan] Take the immediate size in account when narrowing
ia32/x64 word comparison operators.

Powered by Google App Engine
This is Rietveld 408576698