src/debug/debug-scopes.cc - Issue 1995263002: [keys] Simplify KeyAccumulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug-scopes.cc

Issue 1995263002: [keys] Simplify KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix handle dereferencing Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug-scopes.cc

diff --git a/src/debug/debug-scopes.cc b/src/debug/debug-scopes.cc

index 16027110ef6d6ba318566294642ec294b2ad3758..391a6cfe8f0f185d302e2a718bdc1293aa2fe12d 100644

--- a/src/debug/debug-scopes.cc

+++ b/src/debug/debug-scopes.cc

@@ -768,7 +768,7 @@ void ScopeIterator::CopyContextExtensionToScopeObject(

if (context->extension_object() == nullptr) return;

Handle<JSObject> extension(context->extension_object());

Handle<FixedArray> keys =

- JSReceiver::GetKeys(extension, type, ENUMERABLE_STRINGS)

+ KeyAccumulator::GetKeys(extension, type, ENUMERABLE_STRINGS)

.ToHandleChecked();

for (int i = 0; i < keys->length(); i++) {

« no previous file with comments | « src/builtins.cc ('k') | src/elements.cc » ('j') | no next file with comments »