src/json-stringifier.cc - Issue 1995263002: [keys] Simplify KeyAccumulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-stringifier.cc

Issue 1995263002: [keys] Simplify KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressing comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/json-stringifier.cc

diff --git a/src/json-stringifier.cc b/src/json-stringifier.cc

index cc859929d79db46a6114f705ebe4df7f94c2e1c1..68253a60af07c4928d73e0e00226b0184306fd31 100644

--- a/src/json-stringifier.cc

+++ b/src/json-stringifier.cc

@@ -465,7 +465,7 @@ BasicJsonStringifier::Result BasicJsonStringifier::SerializeJSReceiverSlow(

Handle<FixedArray> contents;

ASSIGN_RETURN_ON_EXCEPTION_VALUE(

isolate_, contents,

- JSReceiver::GetKeys(object, OWN_ONLY, ENUMERABLE_STRINGS), EXCEPTION);

+ KeyAccumulator::GetKeys(object, OWN_ONLY, ENUMERABLE_STRINGS), EXCEPTION);

builder_.AppendCharacter('{');

Indent();

« src/elements.cc ('K') | « src/elements.cc ('k') | src/keys.h » ('j') | no next file with comments »