Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/runtime/runtime-object.cc

Issue 1995263002: [keys] Simplify KeyAccumulator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressing comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 RUNTIME_FUNCTION(Runtime_GetOwnPropertyKeys) { 574 RUNTIME_FUNCTION(Runtime_GetOwnPropertyKeys) {
575 HandleScope scope(isolate); 575 HandleScope scope(isolate);
576 DCHECK(args.length() == 2); 576 DCHECK(args.length() == 2);
577 CONVERT_ARG_HANDLE_CHECKED(JSReceiver, object, 0); 577 CONVERT_ARG_HANDLE_CHECKED(JSReceiver, object, 0);
578 CONVERT_SMI_ARG_CHECKED(filter_value, 1); 578 CONVERT_SMI_ARG_CHECKED(filter_value, 1);
579 PropertyFilter filter = static_cast<PropertyFilter>(filter_value); 579 PropertyFilter filter = static_cast<PropertyFilter>(filter_value);
580 580
581 Handle<FixedArray> keys; 581 Handle<FixedArray> keys;
582 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 582 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
583 isolate, keys, 583 isolate, keys,
584 JSReceiver::GetKeys(object, OWN_ONLY, filter, CONVERT_TO_STRING)); 584 KeyAccumulator::GetKeys(object, OWN_ONLY, filter, CONVERT_TO_STRING));
585 585
586 return *isolate->factory()->NewJSArrayWithElements(keys); 586 return *isolate->factory()->NewJSArrayWithElements(keys);
587 } 587 }
588 588
589 589
590 // Return information on whether an object has a named or indexed interceptor. 590 // Return information on whether an object has a named or indexed interceptor.
591 // args[0]: object 591 // args[0]: object
592 RUNTIME_FUNCTION(Runtime_GetInterceptorInfo) { 592 RUNTIME_FUNCTION(Runtime_GetInterceptorInfo) {
593 HandleScope scope(isolate); 593 HandleScope scope(isolate);
594 DCHECK(args.length() == 1); 594 DCHECK(args.length() == 1);
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
1018 isolate, o, key, &success, LookupIterator::OWN); 1018 isolate, o, key, &success, LookupIterator::OWN);
1019 if (!success) return isolate->heap()->exception(); 1019 if (!success) return isolate->heap()->exception();
1020 MAYBE_RETURN( 1020 MAYBE_RETURN(
1021 JSReceiver::CreateDataProperty(&it, value, Object::THROW_ON_ERROR), 1021 JSReceiver::CreateDataProperty(&it, value, Object::THROW_ON_ERROR),
1022 isolate->heap()->exception()); 1022 isolate->heap()->exception());
1023 return *value; 1023 return *value;
1024 } 1024 }
1025 1025
1026 } // namespace internal 1026 } // namespace internal
1027 } // namespace v8 1027 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698