Issue 199523006: Revert "Apply numeric casts correctly in typed arrays and related code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199523006: Revert "Apply numeric casts correctly in typed arrays and related code." (Closed)

Created:
6 years, 9 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Apply numeric casts correctly in typed arrays and related code." This reverts commit r20020 for breaking Win64 build. TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20021

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -152 lines)			Patch
M	src/api.cc	View	1 chunk	+14 lines, -1 line	0 comments	Download
M	src/arraybuffer.js	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/runtime.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	4 chunks	+2 lines, -40 lines	0 comments	Download
M	src/typedarray.js	View	5 chunks	+8 lines, -30 lines	0 comments	Download
D	test/mjsunit/regress/regress-353004.js	View	1 chunk	+0 lines, -74 lines	0 comments	Download

Total messages: 3 (0 generated)

Dmitry Lomov (no reviews)

Committed patchset #1 manually as r20021 (presubmit successful).

6 years, 9 months ago (2014-03-18 10:50:08 UTC) #2

Jakob Kummerow

6 years, 9 months ago (2014-03-18 11:43:20 UTC) #3

Message was sent while issue was closed.

LGTM, although you know that I would have suggested to just land a follow-up
fix.