Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: cc/scheduler/frame_rate_controller.cc

Issue 199523002: cc: Throttle swaps in Scheduler instead of OutputSurface (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: WIP: pulling FRC out of OS Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/scheduler/frame_rate_controller.h" 5 #include "cc/scheduler/frame_rate_controller.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/single_thread_task_runner.h" 11 #include "base/single_thread_task_runner.h"
12 #include "cc/scheduler/delay_based_time_source.h" 12 #include "cc/scheduler/delay_based_time_source.h"
13 #include "cc/scheduler/time_source.h" 13 #include "cc/scheduler/time_source.h"
14 #include "ui/gfx/frame_time.h" 14 #include "ui/gfx/frame_time.h"
15 15
16 namespace cc { 16 namespace cc {
17 17
18 class FrameRateControllerTimeSourceAdapter : public TimeSourceClient { 18 BeginFrameSource::BeginFrameSource(base::TimeDelta interval,
19 public: 19 base::SingleThreadTaskRunner* task_runner)
20 static scoped_ptr<FrameRateControllerTimeSourceAdapter> Create( 20 : client_(NULL), interval_(interval), active_(false) {
21 FrameRateController* frame_rate_controller) { 21 if (gfx::FrameTime::TimestampsAreHighRes())
22 return make_scoped_ptr( 22 time_source_ = DelayBasedTimeSourceHighRes::Create(interval, task_runner);
23 new FrameRateControllerTimeSourceAdapter(frame_rate_controller)); 23 else
24 } 24 time_source_ = DelayBasedTimeSource::Create(interval, task_runner);
25 virtual ~FrameRateControllerTimeSourceAdapter() {} 25 time_source_->SetClient(this);
26
27 virtual void OnTimerTick() OVERRIDE {
28 frame_rate_controller_->OnTimerTick();
29 }
30
31 private:
32 explicit FrameRateControllerTimeSourceAdapter(
33 FrameRateController* frame_rate_controller)
34 : frame_rate_controller_(frame_rate_controller) {}
35
36 FrameRateController* frame_rate_controller_;
37 };
38
39 FrameRateController::FrameRateController(scoped_refptr<TimeSource> timer)
40 : client_(NULL),
41 num_frames_pending_(0),
42 max_swaps_pending_(0),
43 interval_(BeginFrameArgs::DefaultInterval()),
44 time_source_(timer),
45 active_(false),
46 is_time_source_throttling_(true),
47 manual_tick_pending_(false),
48 task_runner_(NULL),
49 weak_factory_(this) {
50 time_source_client_adapter_ =
51 FrameRateControllerTimeSourceAdapter::Create(this);
52 time_source_->SetClient(time_source_client_adapter_.get());
53 } 26 }
54 27
55 FrameRateController::FrameRateController( 28 BeginFrameSource::~BeginFrameSource() { time_source_->SetActive(false); }
56 base::SingleThreadTaskRunner* task_runner)
57 : client_(NULL),
58 num_frames_pending_(0),
59 max_swaps_pending_(0),
60 interval_(BeginFrameArgs::DefaultInterval()),
61 active_(false),
62 is_time_source_throttling_(false),
63 manual_tick_pending_(false),
64 task_runner_(task_runner),
65 weak_factory_(this) {}
66 29
67 FrameRateController::~FrameRateController() { 30 BeginFrameArgs BeginFrameSource::SetActive(bool active) {
68 if (is_time_source_throttling_)
69 time_source_->SetActive(false);
70 }
71
72 BeginFrameArgs FrameRateController::SetActive(bool active) {
73 if (active_ == active) 31 if (active_ == active)
74 return BeginFrameArgs(); 32 return BeginFrameArgs();
75 TRACE_EVENT1("cc", "FrameRateController::SetActive", "active", active); 33 TRACE_EVENT1("cc", "BeginFrameSource::SetActive", "active", active);
76 active_ = active; 34 active_ = active;
77 35
78 if (is_time_source_throttling_) { 36 base::TimeTicks missed_tick_time = time_source_->SetActive(active);
79 base::TimeTicks missed_tick_time = time_source_->SetActive(active); 37 if (!missed_tick_time.is_null()) {
80 if (!missed_tick_time.is_null()) { 38 base::TimeTicks deadline = NextTickTime();
81 base::TimeTicks deadline = NextTickTime(); 39 return BeginFrameArgs::Create(
82 return BeginFrameArgs::Create( 40 missed_tick_time, deadline + deadline_adjustment_, interval_);
83 missed_tick_time, deadline + deadline_adjustment_, interval_);
84 }
85 } else {
86 if (active) {
87 PostManualTick();
88 } else {
89 weak_factory_.InvalidateWeakPtrs();
90 manual_tick_pending_ = false;
91 }
92 } 41 }
93 42
94 return BeginFrameArgs(); 43 return BeginFrameArgs();
95 } 44 }
96 45
97 void FrameRateController::SetMaxSwapsPending(int max_swaps_pending) { 46 void BeginFrameSource::SetTimebaseAndInterval(base::TimeTicks timebase,
98 DCHECK_GE(max_swaps_pending, 0); 47 base::TimeDelta interval) {
99 max_swaps_pending_ = max_swaps_pending; 48 interval_ = interval;
49 time_source_->SetTimebaseAndInterval(timebase, interval);
100 } 50 }
101 51
102 void FrameRateController::SetTimebaseAndInterval(base::TimeTicks timebase, 52 void BeginFrameSource::SetDeadlineAdjustment(base::TimeDelta delta) {
103 base::TimeDelta interval) {
104 interval_ = interval;
105 if (is_time_source_throttling_)
106 time_source_->SetTimebaseAndInterval(timebase, interval);
107 }
108
109 void FrameRateController::SetDeadlineAdjustment(base::TimeDelta delta) {
110 deadline_adjustment_ = delta; 53 deadline_adjustment_ = delta;
111 } 54 }
112 55
113 void FrameRateController::OnTimerTick() { 56 void BeginFrameSource::OnTimerTick() {
114 TRACE_EVENT0("cc", "FrameRateController::OnTimerTick"); 57 TRACE_EVENT0("cc", "BeginFrameSource::OnTimerTick");
115 DCHECK(active_); 58 DCHECK(active_);
116 59
117 // Check if we have too many frames in flight.
118 bool throttled =
119 max_swaps_pending_ && num_frames_pending_ >= max_swaps_pending_;
120 TRACE_COUNTER_ID1("cc", "ThrottledCompositor", task_runner_, throttled);
121
122 if (client_) { 60 if (client_) {
123 // TODO(brianderson): Use an adaptive parent compositor deadline. 61 // TODO(brianderson): Use an adaptive parent compositor deadline.
124 base::TimeTicks frame_time = LastTickTime(); 62 base::TimeTicks frame_time = LastTickTime();
125 base::TimeTicks deadline = NextTickTime(); 63 base::TimeTicks deadline = NextTickTime();
126 BeginFrameArgs args = BeginFrameArgs::Create( 64 BeginFrameArgs args = BeginFrameArgs::Create(
127 frame_time, deadline + deadline_adjustment_, interval_); 65 frame_time, deadline + deadline_adjustment_, interval_);
128 client_->FrameRateControllerTick(throttled, args); 66 client_->BeginImplFrame(args);
129 }
130
131 if (!is_time_source_throttling_ && !throttled)
132 PostManualTick();
133 }
134
135 void FrameRateController::PostManualTick() {
136 if (active_ && !manual_tick_pending_) {
137 manual_tick_pending_ = true;
138 task_runner_->PostTask(FROM_HERE,
139 base::Bind(&FrameRateController::ManualTick,
140 weak_factory_.GetWeakPtr()));
141 } 67 }
142 } 68 }
143 69
144 void FrameRateController::ManualTick() { 70 base::TimeTicks BeginFrameSource::NextTickTime() {
145 manual_tick_pending_ = false; 71 return time_source_->NextTickTime();
146 OnTimerTick();
147 } 72 }
148 73
149 void FrameRateController::DidSwapBuffers() { 74 base::TimeTicks BeginFrameSource::LastTickTime() {
150 num_frames_pending_++; 75 return time_source_->LastTickTime();
151 }
152
153 void FrameRateController::DidSwapBuffersComplete() {
154 DCHECK_GT(num_frames_pending_, 0);
155 num_frames_pending_--;
156 if (!is_time_source_throttling_)
157 PostManualTick();
158 }
159
160 void FrameRateController::DidAbortAllPendingFrames() {
161 num_frames_pending_ = 0;
162 }
163
164 base::TimeTicks FrameRateController::NextTickTime() {
165 if (is_time_source_throttling_)
166 return time_source_->NextTickTime();
167
168 return base::TimeTicks();
169 }
170
171 base::TimeTicks FrameRateController::LastTickTime() {
172 if (is_time_source_throttling_)
173 return time_source_->LastTickTime();
174
175 return gfx::FrameTime::Now();
176 } 76 }
177 77
178 } // namespace cc 78 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698