Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1995203002: Rewrite Shadow DOM distribution engine to support partial synchronous distribution for v1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: wip Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 9f42d72beea41659a076b3d91e52c246d1053caa..b931d2da0dd4f2f5cc777ccc7160675627b8c421 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -3839,6 +3839,11 @@ void Document::nodeChildrenWillBeRemoved(ContainerNode& container)
frame->page()->dragCaretController().nodeWillBeRemoved(n);
}
}
+
+ if (containsV1ShadowTree()) {
+ for (Node& n : NodeTraversal::childrenOf(container))
esprehn 2016/05/23 06:41:00 this traverses the whole subtree again whenever yo
hayato 2016/05/24 13:23:38 My intention to add this check code here, Document
+ n.checkSlotChangeBeforeRemoved();
+ }
}
void Document::nodeWillBeRemoved(Node& n)
@@ -3854,6 +3859,9 @@ void Document::nodeWillBeRemoved(Node& n)
frame->selection().nodeWillBeRemoved(n);
frame->page()->dragCaretController().nodeWillBeRemoved(n);
}
+
+ if (containsV1ShadowTree())
+ n.checkSlotChangeBeforeRemoved();
}
void Document::dataWillChange(const CharacterData& characterData)

Powered by Google App Engine
This is Rietveld 408576698