Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h

Issue 1995203002: Rewrite Shadow DOM distribution engine to support partial synchronous distribution for v1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: No longer FAIL: imported/wpt/shadow-dom/HTMLSlotElement-interface.html Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h
diff --git a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h
index 50c5b48a22efd4a09e0ac9469521c5a90d07e80f..a22758103557976db609a94ce9f48a8d0fd96527 100644
--- a/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h
+++ b/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.h
@@ -5,7 +5,12 @@
#ifndef SlotAssignment_h
#define SlotAssignment_h
+// #include "core/dom/DocumentOrderedList.h"
+#include "core/dom/DocumentOrderedMap.h"
#include "platform/heap/Handle.h"
+#include "wtf/HashMap.h"
+#include "wtf/text/AtomicString.h"
+#include "wtf/text/AtomicStringHash.h"
namespace blink {
@@ -13,37 +18,52 @@ class HTMLSlotElement;
class Node;
class ShadowRoot;
+// TODO(hayato): Support SlotAssignment for non-shadow trees, e.g. a document tree.
class SlotAssignment final : public GarbageCollected<SlotAssignment> {
public:
- static SlotAssignment* create()
+ static SlotAssignment* create(ShadowRoot& owner)
{
- return new SlotAssignment;
+ return new SlotAssignment(owner);
}
- HTMLSlotElement* assignedSlotFor(const Node&) const;
- void resolveAssignment(ShadowRoot&);
- void resolveDistribution(ShadowRoot&);
+ // Relevant DOM Standard: https://dom.spec.whatwg.org/#find-a-slot
+ HTMLSlotElement* findSlot(const Node&);
+ HTMLSlotElement* findSlotByName(const AtomicString& slotName);
- void didAddSlot() { ++m_descendantSlotCount; }
- void didRemoveSlot() { DCHECK_GT(m_descendantSlotCount, 0u); --m_descendantSlotCount; }
- unsigned descendantSlotCount() const { return m_descendantSlotCount; }
+ // DOM Standaard defines these two procedures:
+ // 1. https://dom.spec.whatwg.org/#assign-a-slot
+ // void assignSlot(const Node& slottable);
+ // 2. https://dom.spec.whatwg.org/#assign-slotables
+ // void assignSlotables(HTMLSlotElement&);
+ // As an optimization, Blink does not implement these literally.
+ // Instead, provide alternative, HTMLSlotElement::hasAssignedNodesSlow()
+ // so that slotchange can be detected.
- const HeapVector<Member<HTMLSlotElement>>& descendantSlots() const { return m_descendantSlots; }
+ void resolveDistribution();
+ const HeapVector<Member<HTMLSlotElement>>& slots();
- void setDescendantSlots(HeapVector<Member<HTMLSlotElement>>& slots) { m_descendantSlots.swap(slots); }
- void clearDescendantSlots() { m_descendantSlots.clear(); }
+ void slotAdded(HTMLSlotElement&);
+ void slotRemoved(HTMLSlotElement&);
+ void slotRenamed(const AtomicString& oldName, HTMLSlotElement&);
+ void hostChildSlotNameChanged(const AtomicString& oldValue, const AtomicString& newValue);
+
+ bool findHostChildBySlotName(const AtomicString& slotName) const;
DECLARE_TRACE();
private:
- SlotAssignment() { };
+ explicit SlotAssignment(ShadowRoot& owner);
+
+ void collectSlots();
- void assign(Node&, HTMLSlotElement&);
- void distribute(Node&, HTMLSlotElement&);
+ void resolveAssignment();
+ void distributeTo(Node&, HTMLSlotElement&);
- unsigned m_descendantSlotCount = 0;
- HeapVector<Member<HTMLSlotElement>> m_descendantSlots;
- HeapHashMap<Member<Node>, Member<HTMLSlotElement>> m_assignment;
+ HeapVector<Member<HTMLSlotElement>> m_slots;
+ Member<DocumentOrderedMap> m_slotMap;
+ WeakMember<ShadowRoot> m_owner;
+ unsigned m_needsCollectSlots : 1;
+ unsigned m_slotCount : 31;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp ('k') | third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698