Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1995163002: Test page for rendering throughput for canvas arcs (Closed)

Created:
4 years, 7 months ago by sebastienlc
Modified:
4 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test page for rendering throughput for canvas arcs BUG=606678 Committed: https://crrev.com/6edcd8c85219d193f7f6ada459635a3a295bd72f Cr-Commit-Position: refs/heads/master@{#395488}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -3 lines) Patch
M tools/perf/page_sets/tough_canvas_cases.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/perf/page_sets/tough_canvas_cases/rendering_throughput/bench.js View 1 chunk +1 line, -1 line 0 comments Download
A tools/perf/page_sets/tough_canvas_cases/rendering_throughput/canvas_arcs.html View 1 chunk +38 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_canvas_cases/rendering_throughput/canvas_arcs.js View 1 1 chunk +105 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Justin Novosad
https://codereview.chromium.org/1995163002/diff/1/tools/perf/page_sets/tough_canvas_cases.py File tools/perf/page_sets/tough_canvas_cases.py (right): https://codereview.chromium.org/1995163002/diff/1/tools/perf/page_sets/tough_canvas_cases.py#newcode55 tools/perf/page_sets/tough_canvas_cases.py:55: 'http://acko.net/dumpx/996b.html', Please retire this old test which is redundant ...
4 years, 7 months ago (2016-05-20 18:06:10 UTC) #4
Justin Novosad
+sullivan for OWNERs review.
4 years, 7 months ago (2016-05-20 18:06:54 UTC) #6
sebastienlc
https://codereview.chromium.org/1995163002/diff/1/tools/perf/page_sets/tough_canvas_cases.py File tools/perf/page_sets/tough_canvas_cases.py (right): https://codereview.chromium.org/1995163002/diff/1/tools/perf/page_sets/tough_canvas_cases.py#newcode55 tools/perf/page_sets/tough_canvas_cases.py:55: 'http://acko.net/dumpx/996b.html', On 2016/05/20 18:06:09, Justin Novosad wrote: > Please ...
4 years, 7 months ago (2016-05-20 18:43:52 UTC) #7
Justin Novosad
lgtm. Still need to wait for OWNER confirmation.
4 years, 7 months ago (2016-05-20 18:52:35 UTC) #8
sullivan
lgtm
4 years, 7 months ago (2016-05-23 15:56:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995163002/20001
4 years, 7 months ago (2016-05-23 23:11:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 00:43:35 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 00:46:16 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6edcd8c85219d193f7f6ada459635a3a295bd72f
Cr-Commit-Position: refs/heads/master@{#395488}

Powered by Google App Engine
This is Rietveld 408576698