Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1995123002: Revert of DevTools: Add inertia to flamechart dragging. (Closed)

Created:
4 years, 7 months ago by alph
Modified:
4 years, 7 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Add inertia to flamechart dragging. (patchset #2 id:20001 of https://codereview.chromium.org/1995783002/ ) Reason for revert: Broke item selection on flamechart Original issue's description: > DevTools: Add inertia to flamechart dragging. > > Committed: https://crrev.com/9d73e469f31c85095dd8469dfe72971721310fab > Cr-Commit-Position: refs/heads/master@{#394666} TBR=caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/362b80fad502a8b164499fd7b1269e27441fe277 Cr-Commit-Position: refs/heads/master@{#394839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -97 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 chunk +0 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 5 chunks +21 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
alph
Created Revert of DevTools: Add inertia to flamechart dragging.
4 years, 7 months ago (2016-05-19 19:41:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995123002/1
4 years, 7 months ago (2016-05-19 19:42:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 19:43:03 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 19:44:24 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/362b80fad502a8b164499fd7b1269e27441fe277
Cr-Commit-Position: refs/heads/master@{#394839}

Powered by Google App Engine
This is Rietveld 408576698