chrome/browser/ui/webui/options/language_options_handler_common.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/language_options_handler_common.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc ('k') | chrome/browser/ui/webui/options/manage_profile_handler.cc » ('j') | content/public/browser/web_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/language_options_handler_common.cc

diff --git a/chrome/browser/ui/webui/options/language_options_handler_common.cc b/chrome/browser/ui/webui/options/language_options_handler_common.cc

index 6d3c400a9aa862f790c76dac15f4f77252d755b6..55c8c697302af9ac023ba07b717d26ffefe55c87 100644

--- a/chrome/browser/ui/webui/options/language_options_handler_common.cc

+++ b/chrome/browser/ui/webui/options/language_options_handler_common.cc

@@ -182,21 +182,21 @@ void LanguageOptionsHandlerCommon::OnHunspellDictionaryInitialized(

void LanguageOptionsHandlerCommon::OnHunspellDictionaryDownloadBegin(

const std::string& language) {

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"options.LanguageOptions.onDictionaryDownloadBegin",

base::StringValue(language));

}

void LanguageOptionsHandlerCommon::OnHunspellDictionaryDownloadSuccess(

const std::string& language) {

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"options.LanguageOptions.onDictionaryDownloadSuccess",

base::StringValue(language));

}

void LanguageOptionsHandlerCommon::OnHunspellDictionaryDownloadFailure(

const std::string& language) {

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"options.LanguageOptions.onDictionaryDownloadFailure",

base::StringValue(language));

}

@@ -251,8 +251,8 @@ void LanguageOptionsHandlerCommon::UiLanguageChangeCallback(

content::RecordComputedAction(action);

SetApplicationLocale(language_code);

base::StringValue language_value(language_code);

- web_ui()->CallJavascriptFunction("options.LanguageOptions.uiLanguageSaved",

- language_value);

+ web_ui()->CallJavascriptFunctionUnsafe(

+ "options.LanguageOptions.uiLanguageSaved", language_value);

}

void LanguageOptionsHandlerCommon::SpellCheckLanguageChangeCallback(