chrome/browser/ui/webui/options/chromeos/display_options_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/date_time_options_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/display_overscan_handler.cc » ('j') | content/public/browser/web_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

index 18dc1d0d226b080cdec4a2fb769999bd6234865b..bab117fe3d05f5e9df25b390aec07026da8b2975 100644

--- a/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

@@ -354,8 +354,8 @@ void DisplayOptionsHandler::SendAllDisplayInfo() {

js_displays->Append(js_display);

}

- web_ui()->CallJavascriptFunction("options.DisplayOptions.setDisplayInfo",

- mode, *js_displays);

+ web_ui()->CallJavascriptFunctionUnsafe(

+ "options.DisplayOptions.setDisplayInfo", mode, *js_displays);

}

void DisplayOptionsHandler::UpdateDisplaySettingsEnabled() {

@@ -368,7 +368,7 @@ void DisplayOptionsHandler::UpdateDisplaySettingsEnabled() {

bool unified_enabled = display_manager->unified_desktop_enabled();

bool mirrored_enabled = display_manager->num_connected_displays() == 2;

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"options.BrowserOptions.enableDisplaySettings",

base::FundamentalValue(ui_enabled),

base::FundamentalValue(unified_enabled),