chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/date_time_options_handler.cc » ('j') | content/public/browser/web_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

index 2a27bac5f26809561dca49963b93fd4318a507ff..89c142d3c652eca5b3d9c907cd4e6f662f945ced 100644

--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

@@ -259,9 +259,8 @@ void CoreChromeOSOptionsHandler::SetPref(const std::string& pref_name,

proxy_cros_settings_parser::SetProxyPrefValue(

pref_name, value, &proxy_config_service_);

base::StringValue proxy_type(pref_name);

- web_ui()->CallJavascriptFunction(

- "options.internet.DetailsInternetPage.updateProxySettings",

- proxy_type);

+ web_ui()->CallJavascriptFunctionUnsafe(

+ "options.internet.DetailsInternetPage.updateProxySettings", proxy_type);

ProcessUserMetric(value, metric);

return;

}