Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1995083003: Change LineWidth::fitsOnLine comparison logic (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change LineWidth::fitsOnLine comparison logic Change the LineWidth::fitsOnLine comparison logic to ceil to LayoutUnits instead of adding LayoutUnit::epsilon now that m_availableWidth has been changed to a LayoutUnit instead of a float. R=szager@chromium.org BUG=609427 Committed: https://crrev.com/962b873a492c8036c0286bb55b8c950b31fe866b Cr-Commit-Position: refs/heads/master@{#395230}

Patch Set 1 #

Patch Set 2 : w/TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.h View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eae
Ready for review
4 years, 7 months ago (2016-05-20 22:31:34 UTC) #1
szager1
lgtm
4 years, 7 months ago (2016-05-20 22:41:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995083003/20001
4 years, 7 months ago (2016-05-20 22:46:44 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-21 02:04:29 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 02:05:41 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/962b873a492c8036c0286bb55b8c950b31fe866b
Cr-Commit-Position: refs/heads/master@{#395230}

Powered by Google App Engine
This is Rietveld 408576698