Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1995053002: Reenable WebRtcBrowserTest.CanForwardRemoteStream on vptr bots. (Closed)

Created:
4 years, 7 months ago by krasin
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable WebRtcBrowserTest.CanForwardRemoteStream on vptr bots. BUG=601957 Committed: https://crrev.com/545143c2d3f0b44e3f2d8c118b7402a13d6db631 Cr-Commit-Position: refs/heads/master@{#394952}

Patch Set 1 #

Patch Set 2 : sandbox_linux_unittests on LTO Linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 4 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995053002/1
4 years, 7 months ago (2016-05-19 18:11:38 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/216714)
4 years, 7 months ago (2016-05-19 20:12:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995053002/1
4 years, 7 months ago (2016-05-19 20:32:56 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-19 20:32:58 UTC) #8
krasin
CFI trybot shows that the reenabled test passes: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_cfi_rel_ng/builds/111/steps/content_browsertests%20%28with%20patch%29
4 years, 7 months ago (2016-05-19 20:56:19 UTC) #10
krasin
Also reenabled sandbox_linux_unittests on LTO Linux buildbot as the bug was just fixed: https://crbug.com/612507
4 years, 7 months ago (2016-05-19 21:22:57 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995053002/20001
4 years, 7 months ago (2016-05-19 21:23:54 UTC) #13
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-19 21:44:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995053002/20001
4 years, 7 months ago (2016-05-19 21:45:18 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/216904)
4 years, 7 months ago (2016-05-20 00:13:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995053002/20001
4 years, 7 months ago (2016-05-20 00:27:50 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 01:37:11 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 01:39:50 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/545143c2d3f0b44e3f2d8c118b7402a13d6db631
Cr-Commit-Position: refs/heads/master@{#394952}

Powered by Google App Engine
This is Rietveld 408576698