Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1995043003:
Fix UserManagerBrowserTest (Closed)
|
Created:
4 years, 7 months ago by michaelpg Modified:
4 years, 7 months ago CC:
chromium-reviews, tfarina, pam+watch_chromium.org, arv+watch_chromium.org, michaelpg+watch-md-ui_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix UserManagerBrowserTest
Suppresses the focus() call if the element is not shown, and adds
some time between tests to finish asynchronous microtasks.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
BUG=613191
R=dbeam@chromium.org, mahmadi@chromium.org
TBR=dbeam@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/6d1a8b812ce52ce95301914cb328434ac61ab204
Patch Set 1 #
Total comments: 2
Patch Set 2 : esaber #
Messages
Total messages: 28 (13 generated)
Description was changed from ========== Fix UserManagerBrowserTest ========== to ========== Fix UserManagerBrowserTest CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Fix UserManagerBrowserTest CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Fix UserManagerBrowserTest CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=613191 ==========
michaelpg@chromium.org changed reviewers: + mahmadi@chromium.org
Description was changed from ========== Fix UserManagerBrowserTest CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=613191 ========== to ========== Fix UserManagerBrowserTest Suppresses the focus() call if the element is not shown, and adds some time between tests to finish asynchronous microtasks. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=613191 ==========
Description was changed from ========== Fix UserManagerBrowserTest Suppresses the focus() call if the element is not shown, and adds some time between tests to finish asynchronous microtasks. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=613191 ========== to ========== Fix UserManagerBrowserTest Suppresses the focus() call if the element is not shown, and adds some time between tests to finish asynchronous microtasks. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=613191 TBR=dbeam@chromium.org ==========
michaelpg@chromium.org changed reviewers: + dbeam@chromium.org
On 2016/05/19 19:59:37, michaelpg wrote: lgtm Thanks!
dbeam: PTAL (do I need *committer* approval aside from myself?)
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995043003/1
lgtm https://codereview.chromium.org/1995043003/diff/1/chrome/test/data/webui/md_u... File chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js (right): https://codereview.chromium.org/1995043003/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:31: setTimeout(done); flush()?
https://codereview.chromium.org/1995043003/diff/1/chrome/test/data/webui/md_u... File chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js (right): https://codereview.chromium.org/1995043003/diff/1/chrome/test/data/webui/md_u... chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js:31: setTimeout(done); On 2016/05/19 20:18:35, Dan Beam wrote: > flush()? flush works for DOM, but not async() calls
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995043003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995043003/1
On 2016/05/20 03:29:51, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) gahhh. I want to just "git cl land", and probably will because the test is disabled now, but I noticed this fails on Chrome OS (with and without the patch), what's up with that? ../../chrome/test/base/web_ui_browser_test.cc:474: Failure Value of: web_ui_instance != NULL Actual: false Expected: true [1/1] UserManagerBrowserTest.UserManagerTest (1308 ms) 1 test failed: UserManagerBrowserTest.UserManagerTest (gen/chrome/test/data/webui/md_user_manager/user_manager_browsertest-gen.cc:11)
On 2016/05/20 05:29:54, michaelpg wrote: > On 2016/05/20 03:29:51, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) > > gahhh. I want to just "git cl land", and probably will because the test is > disabled now, but I noticed this fails on Chrome OS (with and without the > patch), what's up with that? > > ../../chrome/test/base/web_ui_browser_test.cc:474: Failure > Value of: web_ui_instance != NULL > Actual: false > Expected: true > [1/1] UserManagerBrowserTest.UserManagerTest (1308 ms) > 1 test failed: > UserManagerBrowserTest.UserManagerTest > (gen/chrome/test/data/webui/md_user_manager/user_manager_browsertest-gen.cc:11) ok, it's excluded from chrome_tests.gypi but not BUILD.gn: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/BUILD.... can you add it there so the test doesn't run on chromeos GN buidlds?
On 2016/05/20 05:33:47, michaelpg wrote: > On 2016/05/20 05:29:54, michaelpg wrote: > > On 2016/05/20 03:29:51, commit-bot: I haz the power wrote: > > > Try jobs failed on following builders: > > > win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, > > > > > > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) > > > > gahhh. I want to just "git cl land", and probably will because the test is > > disabled now, but I noticed this fails on Chrome OS (with and without the > > patch), what's up with that? > > > > ../../chrome/test/base/web_ui_browser_test.cc:474: Failure > > Value of: web_ui_instance != NULL > > Actual: false > > Expected: true > > [1/1] UserManagerBrowserTest.UserManagerTest (1308 ms) > > 1 test failed: > > UserManagerBrowserTest.UserManagerTest > > > (gen/chrome/test/data/webui/md_user_manager/user_manager_browsertest-gen.cc:11) > > ok, it's excluded from chrome_tests.gypi but not BUILD.gn: > > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/BUILD.... > > can you add it there so the test doesn't run on chromeos GN buidlds? or in "browser_tests_js_webui", I guess.
Message was sent while issue was closed.
Description was changed from ========== Fix UserManagerBrowserTest Suppresses the focus() call if the element is not shown, and adds some time between tests to finish asynchronous microtasks. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=613191 TBR=dbeam@chromium.org ========== to ========== Fix UserManagerBrowserTest Suppresses the focus() call if the element is not shown, and adds some time between tests to finish asynchronous microtasks. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=613191 R=dbeam@chromium.org, mahmadi@chromium.org TBR=dbeam@chromium.org Committed: https://crrev.com/6d1a8b812ce52ce95301914cb328434ac61ab204 Cr-Commit-Position: refs/heads/master@{#395006} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6d1a8b812ce52ce95301914cb328434ac61ab204 Cr-Commit-Position: refs/heads/master@{#395006}
Message was sent while issue was closed.
Description was changed from ========== Fix UserManagerBrowserTest Suppresses the focus() call if the element is not shown, and adds some time between tests to finish asynchronous microtasks. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=613191 R=dbeam@chromium.org, mahmadi@chromium.org TBR=dbeam@chromium.org Committed: https://crrev.com/6d1a8b812ce52ce95301914cb328434ac61ab204 Cr-Commit-Position: refs/heads/master@{#395006} ========== to ========== Fix UserManagerBrowserTest Suppresses the focus() call if the element is not shown, and adds some time between tests to finish asynchronous microtasks. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation BUG=613191 R=dbeam@chromium.org, mahmadi@chromium.org TBR=dbeam@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/6d1a8b812ce52ce95301914cb328... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 6d1a8b812ce52ce95301914cb328434ac61ab204 (presubmit successful). |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
