Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1995013003: Removed false dependency from media on the file service interface (Closed)

Created:
4 years, 7 months ago by Sean Klein
Modified:
4 years, 7 months ago
Reviewers:
dalesat, johngro
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Removed false dependency from media on the file service interface Removing this dependency will make extracting Motown from the Mojo codebase significantly easier. BUG=None R=johngro@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b021c0c879149514030037f9308f7619216ab745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M mojo/services/media/core/interfaces/seeking_reader.mojom View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Sean Klein
4 years, 7 months ago (2016-05-19 23:18:38 UTC) #3
johngro
LGTM That said, this is Dale's code, so you might want to wait for his ...
4 years, 7 months ago (2016-05-21 00:35:44 UTC) #5
Sean Klein
4 years, 7 months ago (2016-05-23 16:01:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b021c0c879149514030037f9308f7619216ab745 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698