Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1994963002: [wasm] Move WasmCompilationUnit to .h file. (Closed)

Created:
4 years, 7 months ago by Mircea Trofin
Modified:
4 years, 7 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Move WasmCompilationUnit to .h file. Removed wrapper functions. BUG= Committed: https://crrev.com/d94fbbe0f7aa56ebaa58fa94aff52142d605527c Cr-Commit-Position: refs/heads/master@{#36372}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -190 lines) Patch
M src/compiler/wasm-compiler.h View 4 chunks +36 lines, -15 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 1 chunk +119 lines, -166 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 6 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Mircea Trofin
4 years, 7 months ago (2016-05-19 13:30:25 UTC) #3
ahaas
lgtm
4 years, 7 months ago (2016-05-19 14:47:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994963002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994963002/60001
4 years, 7 months ago (2016-05-19 15:03:14 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-19 15:51:31 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 15:53:11 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d94fbbe0f7aa56ebaa58fa94aff52142d605527c
Cr-Commit-Position: refs/heads/master@{#36372}

Powered by Google App Engine
This is Rietveld 408576698