Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: icu.gyp

Issue 1994903002: gyp: Properly set rtti flag (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu.gyp
diff --git a/icu.gyp b/icu.gyp
index 9675c734ab7621a06086aa5afb713948952297d9..b2bf1dd7fcf33b1da2f13327d5b5f537cde31417 100644
--- a/icu.gyp
+++ b/icu.gyp
@@ -216,6 +216,9 @@
'cflags_cc': [
'-frtti',
],
+ 'cflags_cc!': [
+ '-fno-rtti',
+ ],
'xcode_settings': {
'GCC_ENABLE_CPP_RTTI': 'YES', # -frtti
},
@@ -317,6 +320,9 @@
'cflags_cc': [
'-frtti',
],
+ 'cflags_cc!': [
+ '-fno-rtti',
+ ],
'xcode_settings': {
'GCC_ENABLE_CPP_RTTI': 'YES', # -frtti
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698