Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1994903002: gyp: Properly set rtti flag (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
chromium-reviews, vogelheim, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M icu.gyp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Achenbach
PTAL. Spotted this when diffing gyp/gn. In gyp we currently pass -fno-rtti _and_ -frtti for ...
4 years, 7 months ago (2016-05-19 10:03:11 UTC) #3
vogelheim
lgtm
4 years, 7 months ago (2016-05-19 10:09:53 UTC) #5
jungshik at Google
LGTM
4 years, 7 months ago (2016-05-19 17:24:19 UTC) #6
Michael Achenbach
Committed patchset #1 (id:1) manually as 85bbe1c28e88fdb9a5d113c53c9d7e78c6429659 (presubmit successful).
4 years, 7 months ago (2016-05-19 18:25:24 UTC) #8
Dirk Pranke
4 years, 7 months ago (2016-05-19 18:26:57 UTC) #9
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698