Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.cpp

Issue 1994883002: [Editing][CodeHealth] Extract new FrameCaret class from FrameSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameCaret.cpp
diff --git a/third_party/WebKit/Source/core/loader/CookieJar.h b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
similarity index 69%
copy from third_party/WebKit/Source/core/loader/CookieJar.h
copy to third_party/WebKit/Source/core/editing/FrameCaret.cpp
index 2dc5f08415dc4009b3bd69db8dde19f119743f3b..e171e9ee793fd7ea9a521d91c5ffc821bf624ab2 100644
--- a/third_party/WebKit/Source/core/loader/CookieJar.h
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.cpp
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2003, 2006, 2008, 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -23,21 +23,28 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef CookieJar_h
-#define CookieJar_h
-
-#include "wtf/Forward.h"
-#include "wtf/text/WTFString.h"
+#include "core/editing/FrameCaret.h"
namespace blink {
-class Document;
-class KURL;
+FrameCaret::FrameCaret(LocalFrame* frame)
+ : m_frame(frame)
+ , m_previousCaretVisibility(CaretVisibility::Hidden)
+ , m_caretBlinkTimer(this, &FrameCaret::caretBlinkTimerFired)
+ , m_caretRectDirty(true)
+ , m_shouldPaintCaret(true)
+ , m_isCaretBlinkingSuspended(false)
+{
+ DCHECK(frame);
+}
-String cookies(const Document*, const KURL&);
-void setCookies(Document*, const KURL&, const String& cookieString);
-bool cookiesEnabled(const Document*);
+FrameCaret::~FrameCaret() = default;
-} // namespace blink
+DEFINE_TRACE(FrameCaret)
+{
+ visitor->trace(m_frame);
+ visitor->trace(m_previousCaretNode);
+ CaretBase::trace(visitor);
+}
-#endif
+} // nemaspace blink

Powered by Google App Engine
This is Rietveld 408576698