[Editing][CodeHealth] Extract new FrameCaret class from FrameSelection

third_party/WebKit/Source/core/editing/CaretBase.h

Index: third_party/WebKit/Source/core/editing/CaretBase.h
diff --git a/third_party/WebKit/Source/core/editing/CaretBase.h b/third_party/WebKit/Source/core/editing/CaretBase.h
index 05f064bf9e612fd3b312eb5e0d5694d95e904115..ff14c7b6af3ee2a44347063c789c150fa78c2d42 100644
--- a/third_party/WebKit/Source/core/editing/CaretBase.h
+++ b/third_party/WebKit/Source/core/editing/CaretBase.h
@@ -42,10 +42,11 @@ class LayoutViewItem;
 
 enum class CaretVisibility { Visible, Hidden };
 
-class CORE_EXPORT CaretBase {
+class CORE_EXPORT CaretBase : public  GarbageCollectedFinalized<CaretBase> {
     WTF_MAKE_NONCOPYABLE(CaretBase);
 public:
     explicit CaretBase(CaretVisibility = CaretVisibility::Hidden);
+    virtual ~CaretBase() { }

[yosin_UTC9, 2016/05/20 07:18:05]

nit: virtual dtor should not be inline.
It should be CaretBase::~CaretBase() = default in .cpp file

[yoichio, 2016/05/20 07:49:59]

Done.

 
     void invalidateCaretRect(Node*, bool caretRectChanged = false);
     void clearCaretRect();
@@ -68,6 +69,8 @@ public:
     static LayoutBlock* caretLayoutObject(Node*);
     static void invalidateLocalCaretRect(Node*, const LayoutRect&);
 
+    DEFINE_INLINE_VIRTUAL_TRACE() { }

[yosin_UTC9, 2016/05/20 07:18:05]

nit: Should be in .cpp

[yoichio, 2016/05/20 07:49:59]

Done.

+
 private:
     LayoutRect m_caretLocalRect; // caret rect in coords local to the layoutObject responsible for painting the caret
     CaretVisibility m_caretVisibility;