Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1994863002: Revert of Return E_C_T_OFFLINE when the device is offline (Closed)

Created:
4 years, 7 months ago by tbansal1
Modified:
4 years, 7 months ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Return E_C_T_OFFLINE when the device is offline (patchset #1 id:20001 of https://codereview.chromium.org/1991933002/ ) Reason for revert: Tests failure https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/16114. These tests are failing because the device is offline and this CL adds an early exit in GetEffectiveConnectionType() if the device is offline. Original issue's description: > Return E_C_T_OFFLINE when the device is offline > > Future CL will add additional logic to return E_C_T_OFFLINE > when the device is effectively offline. > > BUG=612883 > > Committed: https://crrev.com/bf0c95b52ea71d32c4d5d38083ea978952516b0e > Cr-Commit-Position: refs/heads/master@{#394603} TBR=bengr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612883 Committed: https://crrev.com/fac10c98b95475adf511e66a2e65b1b33f1daed2 Cr-Commit-Position: refs/heads/master@{#394668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -32 lines) Patch
M net/nqe/network_quality_estimator.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 2 chunks +1 line, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tbansal1
Created Revert of Return E_C_T_OFFLINE when the device is offline
4 years, 7 months ago (2016-05-19 04:16:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994863002/1
4 years, 7 months ago (2016-05-19 04:16:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 04:17:21 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 04:19:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fac10c98b95475adf511e66a2e65b1b33f1daed2
Cr-Commit-Position: refs/heads/master@{#394668}

Powered by Google App Engine
This is Rietveld 408576698