Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1994783002: Make BattOr agent properly handle EOF (Closed)

Created:
4 years, 7 months ago by aschulman
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make BattOr agent properly handle EOF The BattOr agent didn't handle an EOF as input (CTRL-D) and it would go into an infinite loop printing the agent's usage when it received EOF. This fix is needed because it is impossible to script the BattOr agent when it doesn't exit on EOF. BUG=612949 Committed: https://crrev.com/fd630bed0f920d344d94349b11201183bf025eaa Cr-Commit-Position: refs/heads/master@{#394778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/battor_agent/battor_agent_bin.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
charliea (OOO until 10-5)
lgtm w/ nit CL title should describe what the CL does rather than the state ...
4 years, 7 months ago (2016-05-19 14:50:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994783002/1
4 years, 7 months ago (2016-05-19 14:52:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 15:38:46 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 15:42:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd630bed0f920d344d94349b11201183bf025eaa
Cr-Commit-Position: refs/heads/master@{#394778}

Powered by Google App Engine
This is Rietveld 408576698