Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: src/uri.h

Issue 1994733003: Rewrite decodeURL as builtin function, remove now unused runtime functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-strings.cc ('k') | src/uri.cc » ('j') | src/uri.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/uri.h
diff --git a/src/uri.h b/src/uri.h
index e41e8a29e18635403f008bc1fe823a9b1164fc73..417aecdbe34c821c988a7632db59a09bd34cb557 100644
--- a/src/uri.h
+++ b/src/uri.h
@@ -13,23 +13,33 @@ namespace internal {
class Uri : public AllStatic {
public:
- static Object* EncodeUri(Isolate* isolate, Handle<String> uri) {
+ // ES6 section 18.2.6.4 encodeURI (uri)
+ static MaybeHandle<Object> EncodeUri(Isolate* isolate, Handle<String> uri) {
return Encode(isolate, uri, true);
}
- static Object* EncodeUriComponent(Isolate* isolate,
- Handle<String> component) {
+ // ES6 section 18.2.6.5 encodeURIComponenet (uriComponent)
+ static MaybeHandle<Object> EncodeUriComponent(Isolate* isolate,
+ Handle<String> component) {
return Encode(isolate, component, false);
}
- // DecodeUri
- // DecodeUriComponent
- // escape
- // unescape
+ // ES6 section 18.2.6.2 decodeURI (encodedURI)
+ static MaybeHandle<Object> DecodeUri(Isolate* isolate, Handle<String> uri) {
+ return Decode(isolate, uri, true);
+ }
+
+ // ES6 section 18.2.6.3 decodeURIComponent (encodedURIComponent)
+ static MaybeHandle<Object> DecodeUriComponent(Isolate* isolate,
+ Handle<String> component) {
+ return Decode(isolate, component, false);
+ }
private:
- static Object* Encode(Isolate* isolate, Handle<String> uri, bool is_uri);
- // decode
+ static MaybeHandle<Object> Encode(Isolate* isolate, Handle<String> uri,
+ bool is_uri);
+ static MaybeHandle<Object> Decode(Isolate* isolate, Handle<String> uri,
+ bool is_uri);
};
} // namespace internal
« no previous file with comments | « src/runtime/runtime-strings.cc ('k') | src/uri.cc » ('j') | src/uri.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698