Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: src/uri.h

Issue 1994733003: Rewrite decodeURL as builtin function, remove now unused runtime functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use Utf8::Encode() and ValueOf() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/uri.h
diff --git a/src/uri.h b/src/uri.h
index e41e8a29e18635403f008bc1fe823a9b1164fc73..c3a46c3ec3cd2e6b6539761a98acb2db7f32e5a2 100644
--- a/src/uri.h
+++ b/src/uri.h
@@ -22,14 +22,18 @@ class Uri : public AllStatic {
return Encode(isolate, component, false);
}
- // DecodeUri
- // DecodeUriComponent
- // escape
- // unescape
+ static Object* DecodeUri(Isolate* isolate, Handle<String> uri) {
Benedikt Meurer 2016/05/21 19:27:59 Nit: Please add references to the EcmaScript stand
Franzi 2016/05/22 12:34:08 Done.
+ return Decode(isolate, uri, true);
+ }
+
+ static Object* DecodeUriComponent(Isolate* isolate,
Benedikt Meurer 2016/05/21 19:27:59 Nit: Please add references to the EcmaScript stand
Franzi 2016/05/22 12:34:08 Done.
+ Handle<String> component) {
+ return Decode(isolate, component, false);
+ }
private:
static Object* Encode(Isolate* isolate, Handle<String> uri, bool is_uri);
- // decode
+ static Object* Decode(Isolate* isolate, Handle<String> uri, bool is_uri);
};
} // namespace internal
« src/builtins.cc ('K') | « src/runtime/runtime-strings.cc ('k') | src/uri.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698