Rewrite decodeURL as builtin function, remove now unused runtime functions.

src/uri.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_URI_H_
 #define V8_URI_H_
 
 #include "src/allocation.h"
 #include "src/objects.h"
 
 namespace v8 {
 namespace internal {
 
 class Uri : public AllStatic {

[Benedikt Meurer, 2016/05/21 19:27:59]

I'd rather handlify these functions completely. Returning naked Object pointers
was a major source of bugs in the past (sorry, didn't comment on the CL that
introduced Uri the week before).

So if this is OK with Yang, then please change these functions to return
MaybeHandle<Object> instead of Object*.

[Franzi, 2016/05/22 12:34:08]

Done.

  public:
   static Object* EncodeUri(Isolate* isolate, Handle<String> uri) {
     return Encode(isolate, uri, true);
   }
 
   static Object* EncodeUriComponent(Isolate* isolate,
                                     Handle<String> component) {
     return Encode(isolate, component, false);
   }
 
-  // DecodeUri
-  // DecodeUriComponent
-  // escape
-  // unescape
+  static Object* DecodeUri(Isolate* isolate, Handle<String> uri) {

[Benedikt Meurer, 2016/05/21 19:27:59]

Nit: Please add references to the EcmaScript standard.

[Franzi, 2016/05/22 12:34:08]

Done.

+    return Decode(isolate, uri, true);
+  }
+
+  static Object* DecodeUriComponent(Isolate* isolate,

[Benedikt Meurer, 2016/05/21 19:27:59]

Nit: Please add references to the EcmaScript standard.

[Franzi, 2016/05/22 12:34:08]

Done.

+                                    Handle<String> component) {
+    return Decode(isolate, component, false);
+  }
 
  private:
   static Object* Encode(Isolate* isolate, Handle<String> uri, bool is_uri);
-  // decode
+  static Object* Decode(Isolate* isolate, Handle<String> uri, bool is_uri);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_URI_H_