Rewrite decodeURL as builtin function, remove now unused runtime functions.

src/builtins.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins.h"
 
 #include "src/api-arguments.h"
 #include "src/api-natives.h"
 #include "src/api.h"
 #include "src/base/once.h"
@@ skipping 2085 matching lines @@
   HandleScope scope(isolate);
   Handle<Object> object = args.atOrUndefined(isolate, 1);
   if (object->IsJSReceiver()) {
     MAYBE_RETURN(JSReceiver::SetIntegrityLevel(Handle<JSReceiver>::cast(object),
                                                SEALED, Object::THROW_ON_ERROR),
                  isolate->heap()->exception());
   }
   return *object;
 }
 
+// ES6 section 18.2.6.2 decodeURI (encodedURI)
+BUILTIN(GlobalDecodeURI) {
+  HandleScope scope(isolate);
+  Handle<String> encodedURI;

[Benedikt Meurer, 2016/05/21 19:27:59]

Nit: Please rename to encoded_uri.

[Franzi, 2016/05/22 12:34:08]

Done.

+  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
+      isolate, encodedURI,
+      Object::ToString(isolate, args.atOrUndefined(isolate, 1)));
+  return Uri::DecodeUri(isolate, encodedURI);
+}
+
+// ES6 section 18.2.6.3 decodeURIComponent (encodedURIComponent)
+BUILTIN(GlobalDecodeURIComponent) {
+  HandleScope scope(isolate);
+  Handle<String> encodedURIComponent;

[Benedikt Meurer, 2016/05/21 19:27:59]

Nit: Please rename to encoded_uri_component.

[Franzi, 2016/05/22 12:34:08]

Done. Changed it in encodeURIComponent as well. 

+  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
+      isolate, encodedURIComponent,
+      Object::ToString(isolate, args.atOrUndefined(isolate, 1)));
+  return Uri::DecodeUriComponent(isolate, encodedURIComponent);
+}
+
 // ES6 section 18.2.6.4 encodeURI (uri)
 BUILTIN(GlobalEncodeURI) {
   HandleScope scope(isolate);
   Handle<String> uri;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
       isolate, uri, Object::ToString(isolate, args.atOrUndefined(isolate, 1)));
-
   return Uri::EncodeUri(isolate, uri);
 }
 
 // ES6 section 18.2.6.5 encodeURIComponenet (uriComponent)
 BUILTIN(GlobalEncodeURIComponent) {
   HandleScope scope(isolate);
   Handle<String> uriComponent;
   ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
       isolate, uriComponent,
       Object::ToString(isolate, args.atOrUndefined(isolate, 1)));
-
   return Uri::EncodeUriComponent(isolate, uriComponent);
 }
 
 namespace {
 
 bool CodeGenerationFromStringsAllowed(Isolate* isolate,
                                       Handle<Context> context) {
   DCHECK(context->allow_code_gen_from_strings()->IsFalse());
   // Check with callback if set.
   AllowCodeGenerationFromStringsCallback callback =
@@ skipping 3382 matching lines @@
 BUILTIN_LIST_T(DEFINE_BUILTIN_ACCESSOR_T)
 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
 #undef DEFINE_BUILTIN_ACCESSOR_C
 #undef DEFINE_BUILTIN_ACCESSOR_A
 #undef DEFINE_BUILTIN_ACCESSOR_T
 #undef DEFINE_BUILTIN_ACCESSOR_H
 
 }  // namespace internal
 }  // namespace v8