Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: build/config/BUILD.gn

Issue 1994713002: Make the dependency of enable_print_preview and enable_pdf explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix cc file Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/utility/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 0ca8e18a5bb1ecef7d74ecac665bcab4a6d07a69..cc2ffb3c6ee815a4003c0dbc94ab225fadba122a 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -82,6 +82,12 @@ config("feature_flags") {
# Can be defined without ENABLE_BASIC_PRINTING.
defines += [ "ENABLE_PRINT_PREVIEW=1" ]
}
+ if ((enable_basic_printing && is_win) || enable_print_preview) {
+ # Windows basic printing or print preview requires pdf enabled.
+ assert(enable_pdf,
+ "Windows basic printing or print preview needs pdf: " +
+ "set enable_pdf=true.")
+ }
}
if (enable_spellcheck) {
defines += [ "ENABLE_SPELLCHECK=1" ]
« no previous file with comments | « no previous file | chrome/utility/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698