Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 1994703003: Remove mutex for retrieving default typeface. (Closed)

Created:
4 years, 7 months ago by bungeman-skia
Modified:
4 years, 7 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove mutex for retrieving default typeface. This mutex was added due to FontConfigTypeface::LegacyCreateTypeface being non-thread safe. This method no longer exists and the logic was moved to SkFontMgr_FCI::onLegacyCreateTypeface which has access to an appropriate mutex ("Clean up SkFontConfigInterface implementation.", 0265707c191a31dfde08dd1cd7011c1fe5b8e643). Committed: https://skia.googlesource.com/skia/+/c989e1851ee6b1be2b5b56129efcd14cfafb31d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/core/SkTypeface.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994703003/1
4 years, 7 months ago (2016-05-19 17:02:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 17:22:30 UTC) #6
bungeman-skia
4 years, 7 months ago (2016-05-19 17:48:11 UTC) #8
reed1
lgtm
4 years, 7 months ago (2016-05-19 18:18:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994703003/1
4 years, 7 months ago (2016-05-19 18:23:00 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:24:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c989e1851ee6b1be2b5b56129efcd14cfafb31d8

Powered by Google App Engine
This is Rietveld 408576698