Fix the views Task Manager on Mac showing 0s for the Shared Memory

Fix the views Task Manager on Mac showing 0s for the Shared Memory

R=nick@chromium.org
BUG=613025
Committed: https://crrev.com/07a8e7b48eeff1b271e50ea371d8c7e722ee3891
Cr-Commit-Position: refs/heads/master@{#395129}

[afakhry, 2016-05-19 18:16:47]

Nick, Please review. Thanks!

[ncarter (slow), 2016-05-19 22:29:10]

Looks like you have mac compile failures. Since it's a small patch, I'll review
once those are fixed.

[ncarter (slow), 2016-05-19 22:30:36]

https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_managem...
File chrome/browser/task_management/sampling/task_group_sampler.cc (left):

https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_managem...
chrome/browser/task_management/sampling/task_group_sampler.cc:126: // on Windows
here.
Did we ever do this?

[afakhry, 2016-05-20 00:34:35]

https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_managem...
File chrome/browser/task_management/sampling/task_group_sampler.cc (left):

https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_managem...
chrome/browser/task_management/sampling/task_group_sampler.cc:126: // on Windows
here.
On 2016/05/19 22:30:36, ncarter wrote:
> Did we ever do this?

We haven't. One reason was that Bruce's approach doesn't match our
task/group/group sampler architecture.

I wanted to discuss this with you, actually. I think it's not worth it adding
ugliness and code complexity to our design, from which the return is not big.
Our design is already fast and running in a background thread. WDT? I can leave
that TODO if you want.

[ncarter (slow), 2016-05-20 16:58:21]

On 2016/05/20 00:34:35, afakhry wrote:
>
https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_managem...
> File chrome/browser/task_management/sampling/task_group_sampler.cc (left):
> 
>
https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_managem...
> chrome/browser/task_management/sampling/task_group_sampler.cc:126: // on
Windows
> here.
> On 2016/05/19 22:30:36, ncarter wrote:
> > Did we ever do this?
> 
> We haven't. One reason was that Bruce's approach doesn't match our
> task/group/group sampler architecture.
> 
> I wanted to discuss this with you, actually. I think it's not worth it adding
> ugliness and code complexity to our design, from which the return is not big.
> Our design is already fast and running in a background thread. WDT? I can
leave
> that TODO if you want.

The return was huge, though, right? The architecture should adapt to the best
way to operate.

Let me own this.

[ncarter (slow), 2016-05-20 17:45:35]

lgtm

[afakhry, 2016-05-20 18:25:23]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-05-20 18:25:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994653006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994653006/20001

[afakhry, 2016-05-20 18:29:17]

On 2016/05/20 16:58:21, ncarter wrote:
> On 2016/05/20 00:34:35, afakhry wrote:
> >
>
https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_managem...
> > File chrome/browser/task_management/sampling/task_group_sampler.cc (left):
> > 
> >
>
https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_managem...
> > chrome/browser/task_management/sampling/task_group_sampler.cc:126: // on
> Windows
> > here.
> > On 2016/05/19 22:30:36, ncarter wrote:
> > > Did we ever do this?
> > 
> > We haven't. One reason was that Bruce's approach doesn't match our
> > task/group/group sampler architecture.
> > 
> > I wanted to discuss this with you, actually. I think it's not worth it
adding
> > ugliness and code complexity to our design, from which the return is not
big.
> > Our design is already fast and running in a background thread. WDT? I can
> leave
> > that TODO if you want.
> 
> The return was huge, though, right? The architecture should adapt to the best
> way to operate.
> 
> Let me own this.

I'm not sure about the return because that was a Windows-only optimization.

[commit-bot: I haz the power, 2016-05-20 19:09:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-20 19:12:18]

Description was changed from

==========
Fix the views Task Manager on Mac showing 0s for the Shared Memory

R=nick@chromium.org
BUG=613025
==========

to

==========
Fix the views Task Manager on Mac showing 0s for the Shared Memory

R=nick@chromium.org
BUG=613025

Committed: https://crrev.com/07a8e7b48eeff1b271e50ea371d8c7e722ee3891
Cr-Commit-Position: refs/heads/master@{#395129}
==========

[commit-bot: I haz the power, 2016-05-20 19:12:18]

Patchset 2 (id:??) landed as
https://crrev.com/07a8e7b48eeff1b271e50ea371d8c7e722ee3891
Cr-Commit-Position: refs/heads/master@{#395129}