Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1994653006: Fix the views Task Manager on Mac showing 0s for the Shared Memory (Closed)

Created:
4 years, 7 months ago by afakhry
Modified:
4 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the views Task Manager on Mac showing 0s for the Shared Memory R=nick@chromium.org BUG=613025 Committed: https://crrev.com/07a8e7b48eeff1b271e50ea371d8c7e722ee3891 Cr-Commit-Position: refs/heads/master@{#395129}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix compile errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M chrome/browser/task_management/sampling/task_group_sampler.cc View 1 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
afakhry
Nick, Please review. Thanks!
4 years, 7 months ago (2016-05-19 18:16:47 UTC) #1
ncarter (slow)
Looks like you have mac compile failures. Since it's a small patch, I'll review once ...
4 years, 7 months ago (2016-05-19 22:29:10 UTC) #2
ncarter (slow)
https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_management/sampling/task_group_sampler.cc File chrome/browser/task_management/sampling/task_group_sampler.cc (left): https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_management/sampling/task_group_sampler.cc#oldcode126 chrome/browser/task_management/sampling/task_group_sampler.cc:126: // on Windows here. Did we ever do this?
4 years, 7 months ago (2016-05-19 22:30:36 UTC) #3
afakhry
https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_management/sampling/task_group_sampler.cc File chrome/browser/task_management/sampling/task_group_sampler.cc (left): https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_management/sampling/task_group_sampler.cc#oldcode126 chrome/browser/task_management/sampling/task_group_sampler.cc:126: // on Windows here. On 2016/05/19 22:30:36, ncarter wrote: ...
4 years, 7 months ago (2016-05-20 00:34:35 UTC) #4
ncarter (slow)
On 2016/05/20 00:34:35, afakhry wrote: > https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_management/sampling/task_group_sampler.cc > File chrome/browser/task_management/sampling/task_group_sampler.cc (left): > > https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_management/sampling/task_group_sampler.cc#oldcode126 > ...
4 years, 7 months ago (2016-05-20 16:58:21 UTC) #5
ncarter (slow)
lgtm
4 years, 7 months ago (2016-05-20 17:45:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994653006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994653006/20001
4 years, 7 months ago (2016-05-20 18:25:35 UTC) #8
afakhry
On 2016/05/20 16:58:21, ncarter wrote: > On 2016/05/20 00:34:35, afakhry wrote: > > > https://codereview.chromium.org/1994653006/diff/1/chrome/browser/task_management/sampling/task_group_sampler.cc ...
4 years, 7 months ago (2016-05-20 18:29:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 19:09:42 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 19:12:18 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07a8e7b48eeff1b271e50ea371d8c7e722ee3891
Cr-Commit-Position: refs/heads/master@{#395129}

Powered by Google App Engine
This is Rietveld 408576698