Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1994653002:
[heap] Replace RELOCATED_CODE_OBJECT with proper recording (Closed)
|
Created:
4 years, 7 months ago by Michael Lippautz Modified:
4 years, 7 months ago Reviewers:
ulan CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, ahaas, titzer Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Replace RELOCATED_CODE_OBJECT with proper recording
Properly records entries individually instead of using the hammer that requires
visiting the whole code object during pointer updating.
BUG=chromium:612847
LOG=N
Committed: https://crrev.com/768e9c509bfdbb092b392f62cc128a2a451b0490
Cr-Commit-Position: refs/heads/master@{#36334}
Patch Set 1 #Patch Set 2 : Harden check for VistCodeAgeSequence #Patch Set 3 : #
Messages
Total messages: 21 (12 generated)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994653002/1
Description was changed from ========== [heap] Remove RELOCATED_CODE_OBJECT with proper recording Properly records entries individually instead of using the hammer that requires visiting the whole code object during pointer updating. BUG= ========== to ========== [heap] Replace RELOCATED_CODE_OBJECT with proper recording Properly records entries individually instead of using the hammer that requires visiting the whole code object during pointer updating. BUG= ==========
Description was changed from ========== [heap] Replace RELOCATED_CODE_OBJECT with proper recording Properly records entries individually instead of using the hammer that requires visiting the whole code object during pointer updating. BUG= ========== to ========== [heap] Replace RELOCATED_CODE_OBJECT with proper recording Properly records entries individually instead of using the hammer that requires visiting the whole code object during pointer updating. BUG=chromium:612847 LOG=N ==========
mlippautz@chromium.org changed reviewers: + ulan@chromium.org
ulan: ptal wasm: fyi (first part of getting recording for typed old->new slots)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, thank you!
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/1994653002/#ps20001 (title: "Harden check for VistCodeAgeSequence")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/1994653002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994653002/40001
Message was sent while issue was closed.
Description was changed from ========== [heap] Replace RELOCATED_CODE_OBJECT with proper recording Properly records entries individually instead of using the hammer that requires visiting the whole code object during pointer updating. BUG=chromium:612847 LOG=N ========== to ========== [heap] Replace RELOCATED_CODE_OBJECT with proper recording Properly records entries individually instead of using the hammer that requires visiting the whole code object during pointer updating. BUG=chromium:612847 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Replace RELOCATED_CODE_OBJECT with proper recording Properly records entries individually instead of using the hammer that requires visiting the whole code object during pointer updating. BUG=chromium:612847 LOG=N ========== to ========== [heap] Replace RELOCATED_CODE_OBJECT with proper recording Properly records entries individually instead of using the hammer that requires visiting the whole code object during pointer updating. BUG=chromium:612847 LOG=N Committed: https://crrev.com/768e9c509bfdbb092b392f62cc128a2a451b0490 Cr-Commit-Position: refs/heads/master@{#36334} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/768e9c509bfdbb092b392f62cc128a2a451b0490 Cr-Commit-Position: refs/heads/master@{#36334} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
