Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1994633003: use another elf.h inside the package for common/dwarf/elf_reader (Closed)

Created:
4 years, 7 months ago by yunlian
Modified:
4 years, 7 months ago
Reviewers:
michaelbai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

use another elf.h inside the package for common/dwarf/elf_reader We tried to use common/android/include/elf.h, however it contains '#include-next elf.h' so it still breaks MAC build. So we use third_party/musl/include/elf.h instead. BUG=none TEST=make; make test passes. There is no '#include-next elf.h' in the new elf.h R=michaelbai@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/e35167de7516448fcc2bf687ad580b9d8b6aedc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/common/dwarf/elf_reader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
yunlian
4 years, 7 months ago (2016-05-18 21:59:35 UTC) #2
michaelbai
lgtm
4 years, 7 months ago (2016-05-18 22:02:19 UTC) #3
yunlian
4 years, 7 months ago (2016-05-18 22:06:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e35167de7516448fcc2bf687ad580b9d8b6aedc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698