Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1994623002: Make Uri.parse("data:...") go through UriData.parse. (Closed)

Created:
4 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Uri.parse("data:...") go through UriData.parse. It's safer to not try to do part normalization on data: URI content, and it's likely to be faster to parse it only once. This should also reduce the work done when parsing data: URIs using Uri.parse. BUG= https://github.com/dart-lang/sdk/issues/26280 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/3a1a7c3968f151e61b4a41f734fea268ac804ddf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M sdk/lib/core/uri.dart View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
4 years, 7 months ago (2016-05-18 13:49:59 UTC) #2
floitsch
LGTM.
4 years, 7 months ago (2016-05-18 13:50:50 UTC) #3
Lasse Reichstein Nielsen
4 years, 7 months ago (2016-05-19 09:27:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a1a7c3968f151e61b4a41f734fea268ac804ddf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698