[SVG] Handle animation freeze when 'repeatDur' is not a multiple of 'dur'

[SVG] Handle animation freeze when 'repeatDur' is not a multiple of 'dur'

This logic originally existed in WebKit as 'if (fmod(repeatingDuration.value(), simpleDuration.value() == 0.))'.
It was supposed to read `if (fmod(...) == 0)`, but the == slipped into the fmod call and unfortunately got removed later as it looked meaningless.
This logic is meant for handling the scenario where 'repeatingDuration' is not a multiple of 'simpleDuration'.
Modified this logic in a proper way.

R=pdr@chromium.org, schenney@chromium.org, dschulze@chromium.org
BUG=262917
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154777

[pavane, 2013-07-22 13:00:54]

Please have a look at this patch.

There was some discussion about it long back in webkit. Please refer to the
below URL:

https://bugs.webkit.org/show_bug.cgi?id=94756

Thanks and Regards,
Pavan

[pavane, 2013-07-22 13:02:30]

Please have a look at this patch.

There was some discussion about it long back in webkit. Please refer to the
below URL:

https://bugs.webkit.org/show_bug.cgi?id=94756

Thanks and Regards,
Pavan

[Stephen Chennney, 2013-07-22 13:42:09]

There is a js test suite for animation tests that avoids the ref-test - this
should be tested using that framework. See the examples in
LayoutTests/svg/animations

Right now there is too much extraneous stuff in the test case.

Code fix seems fine,

[pavane, 2013-07-23 13:32:26]

Changes done.

I am wondering why the diff is shown along with some random file even when i add
a new file. Ideally i expect it to compare with null. Am i wrong in some way or
there is a problem with upload system?

[Stephen Chennney, 2013-07-23 18:01:12]

On 2013/07/23 13:32:26, pavane wrote:
> Changes done.
> 
> I am wondering why the diff is shown along with some random file even when i
add
> a new file. Ideally i expect it to compare with null. Am i wrong in some way
or
> there is a problem with upload system?

It's just a problem with the git cl upload. There's a way to avoid it, via the
similarity metric, but I don't know exactly how.

[Stephen Chennney, 2013-07-23 18:05:54]

lgtm

Excellent. LGTM.

[commit-bot: I haz the power, 2013-07-23 18:06:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pavan.e@samsung.com/19946002/6001

[commit-bot: I haz the power, 2013-07-23 20:06:13]

Change committed as 154777

[pdr., 2013-07-23 22:01:34]

On 2013/07/23 20:06:13, I haz the power (commit-bot) wrote:
> Change committed as 154777

Upload your patch like so to avoid the strange diffs:
git cl upload --no-find-copies --similarity=100

Most of the time git cl upload gets it right but, like this patch, it sometimes
fails in fun ways :P