Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1994593002: only use kAccessibilityEnabled inside USE_GCONF ifdef blocks (Closed)

Created:
4 years, 7 months ago by Mostyn Bramley-Moore
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni, kraynov, dcheng
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

only use kAccessibilityEnabled inside USE_GCONF ifdef blocks Followup to https://codereview.chromium.org/1990453002 BUG=486077

Patch Set 1 #

Patch Set 2 : re-up, attempt to avoid spurious presubmit failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/accessibility/platform/atk_util_auralinux.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994593002/1
4 years, 7 months ago (2016-05-18 11:19:55 UTC) #2
Mostyn Bramley-Moore
@Andrey, dmazzoni: please take a look at this small fixup to https://codereview.chromium.org/1990453002 for builds with ...
4 years, 7 months ago (2016-05-18 11:20:45 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/185313)
4 years, 7 months ago (2016-05-18 11:26:43 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994593002/20001
4 years, 7 months ago (2016-05-18 11:33:53 UTC) #8
Mostyn Bramley-Moore
I think this patch is OK, but somehow rietveld thinks it depends on dcheng's cheddar ...
4 years, 7 months ago (2016-05-18 11:34:43 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/185321)
4 years, 7 months ago (2016-05-18 11:39:22 UTC) #12
Mostyn Bramley-Moore
4 years, 7 months ago (2016-05-18 11:53:20 UTC) #14

Powered by Google App Engine
This is Rietveld 408576698