Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1994543002: Revert of Ship Turbofan optimization for try-catch and try-finally. (Closed)

Created:
4 years, 7 months ago by Michael Hablich
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, mvstanton, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Ship Turbofan optimization for try-catch and try-finally. (patchset #1 id:1 of https://codereview.chromium.org/1946883003/ ) Reason for revert: Reverted because of BUG=chromium:611885 Original issue's description: > Ship Turbofan optimization for try-catch and try-finally. > > Committed: https://crrev.com/b84b01e6d2d8a0ed1e6b9186a5af755bab4bac9a > Cr-Commit-Position: refs/heads/master@{#36005} TBR=bmeurer@chromium.org,jarin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/cab4685e3515a69de8d920d1a2c5a531c87fc3d7 Cr-Commit-Position: refs/heads/master@{#36309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ast/ast-numbering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Hablich
Created Revert of Ship Turbofan optimization for try-catch and try-finally.
4 years, 7 months ago (2016-05-18 07:14:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994543002/1
4 years, 7 months ago (2016-05-18 07:14:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994543002/1
4 years, 7 months ago (2016-05-18 07:31:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 07:48:53 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 07:49:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cab4685e3515a69de8d920d1a2c5a531c87fc3d7
Cr-Commit-Position: refs/heads/master@{#36309}

Powered by Google App Engine
This is Rietveld 408576698