Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1994533002: [turbofan] We never use Int64Constant for branch/select conditions. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] We never use Int64Constant for branch/select conditions. Remove dead code to optimize Int64Constants as branch/select conditions, because we either have tagged booleans or bits represented as word32. R=jarin@chromium.org Committed: https://crrev.com/91a2ea815b5e22ae7b9223c489757fa89fae8ef5 Cr-Commit-Position: refs/heads/master@{#36308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M src/compiler/common-operator-reducer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 2 chunks +0 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-18 06:49:47 UTC) #1
Benedikt Meurer
Hey Jaro, Some dead code removal, red-only. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-18 06:50:23 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-18 06:54:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994533002/1
4 years, 7 months ago (2016-05-18 06:55:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 07:19:58 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 07:20:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91a2ea815b5e22ae7b9223c489757fa89fae8ef5
Cr-Commit-Position: refs/heads/master@{#36308}

Powered by Google App Engine
This is Rietveld 408576698