Support Mac system hyphenation dictionary

Support Mac system hyphenation dictionary

This patch supports hyphenation dictionary for Mac using Core
Foundation API.

BUG=605840
Committed: https://crrev.com/c1d8f02d2ebf6dbaeb7f593c6a75ee494a900ca1
Cr-Commit-Position: refs/heads/master@{#394388}

[kojii, 2016-05-18 03:57:34]

Description was changed from

==========
hyphens-mac

BUG=
==========

to

==========
Support Mac system hyphenation dictionary

This patch supports hyphenation dictionary for Mac using Core
Foundation API.

BUG=605840
==========

[kojii, 2016-05-18 03:57:46]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2016-05-18 03:57:46]

PTAL.

[drott, 2016-05-18 08:40:41]

Code changes looks good to me. Is the platformGetHyphenation exercised in a test
somewhere already? Or could we add a basic gtest to validate this CL and the
sandbox rules change?

[kojii, 2016-05-18 10:56:22]

On 2016/05/18 at 08:40:41, drott wrote:
> Code changes looks good to me. Is the platformGetHyphenation exercised in a
test somewhere already? Or could we add a basic gtest to validate this CL and
the sandbox rules change?

Good point, added a test without "internals.setMockHyphenation", only for Mac
for now.

[drott, 2016-05-18 10:58:57]

Thanks, LGTM.

[kojii, 2016-05-18 11:45:16]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-05-18 11:45:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994443002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994443002/40001

[commit-bot: I haz the power, 2016-05-18 11:58:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-18 11:59:53]

Description was changed from

==========
Support Mac system hyphenation dictionary

This patch supports hyphenation dictionary for Mac using Core
Foundation API.

BUG=605840
==========

to

==========
Support Mac system hyphenation dictionary

This patch supports hyphenation dictionary for Mac using Core
Foundation API.

BUG=605840

Committed: https://crrev.com/c1d8f02d2ebf6dbaeb7f593c6a75ee494a900ca1
Cr-Commit-Position: refs/heads/master@{#394388}
==========

[commit-bot: I haz the power, 2016-05-18 11:59:54]

Patchset 3 (id:??) landed as
https://crrev.com/c1d8f02d2ebf6dbaeb7f593c6a75ee494a900ca1
Cr-Commit-Position: refs/heads/master@{#394388}