content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc - Issue 199443004: gpu: Raise GL_OUT_OF_MEMORY when BeginQueryEXT fails to allocate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

Issue 199443004: gpu: Raise GL_OUT_OF_MEMORY when BeginQueryEXT fails to allocate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: checkmem: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h ('k') | content/renderer/render_thread_impl.cc » ('j') | gpu/command_buffer/client/gles2_implementation.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

index 4b91c424cf3e7d477dfb36404b238f138c2264b0..465986fbafcb794589992b0036045169a508b11a 100644

--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

@@ -350,6 +350,8 @@ bool WebGraphicsContext3DCommandBufferImpl::InitializeCommandBuffer(

attribs.push_back(attributes_.antialias ? 1 : 0);

attribs.push_back(FAIL_IF_MAJOR_PERF_CAVEAT);

attribs.push_back(attributes_.failIfMajorPerformanceCaveat ? 1 : 0);

+ attribs.push_back(LOSE_CONTEXT_WHEN_OUT_OF_MEMORY);

+ attribs.push_back(attributes_.loseContextWhenOutOfMemory ? 1 : 0);

attribs.push_back(NONE);

// Create a proxy to a command buffer in the GPU process.

@@ -429,6 +431,7 @@ bool WebGraphicsContext3DCommandBufferImpl::CreateContext(bool onscreen) {

gles2_share_group,

transfer_buffer_.get(),

bind_generates_resources_,

+ attributes_.loseContextWhenOutOfMemory,

command_buffer_.get()));

gl_ = real_gl_.get();